Ticket #9154 (closed defect: duplicate)

Opened 2 years ago

Last modified 7 months ago

ticket deletion error

Reported by: sb@waeme.net Assigned to: rjollos
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (Last modified by rjollos)

Error while deleting ticket:

Traceback (most recent call last):
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/trac/admin/console.py", line 107, in onecmd
    rv = cmd.Cmd.onecmd(self, line) or 0
  File "/usr/local/lib/python2.6/cmd.py", line 218, in onecmd
    return self.default(line)
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/trac/admin/console.py", line 266, in default
    return cmd_mgr.execute_command(*args)
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/trac/admin/api.py", line 123, in execute_command
    return f(*fargs)
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/trac/ticket/admin.py", line 838, in _do_remove
    @self.env.with_transaction()
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/trac/db/api.py", line 77, in transaction_wrapper
    fn(ldb)
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/trac/ticket/admin.py", line 841, in do_remove
    ticket.delete()
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/trac/ticket/model.py", line 421, in delete
    listener.ticket_deleted(self)
  File "build/bdist.freebsd-8.2-STABLE-amd64/egg/announcer/subscribers.py", line 844, in ticket_deleted
    self.env, klass, 'ticket', page.name)
NameError: global name 'page' is not defined

caused by typo in WatchSubscriber.ticket_deleted.

Fix:

  • subscribers.py

    old new  
    841841    def ticket_deleted(self, ticket): 
    842842        klass = self.__class__.__name__ 
    843843        SubscriptionAttribute.delete_by_class_realm_and_target( 
    844                 self.env, klass, 'ticket', page.name) 
     844                self.env, klass, 'ticket', ticket.name) 
    845845        db = self.env.get_db_cnx() 
    846846 
    847847    def matches(self, event): 

Attachments

Change History

09/07/11 17:57:20 changed by sb@waeme.net

Correct patch actually looks like:

@@ -841,7 +841,7 @@
     def ticket_deleted(self, ticket):
         klass = self.__class__.__name__
         SubscriptionAttribute.delete_by_class_realm_and_target(
-                self.env, klass, 'ticket', page.name)
+                self.env, klass, 'ticket', self._get_target_id(ticket))
         db = self.env.get_db_cnx()
 
     def matches(self, event):

02/02/12 08:23:10 changed by rjollos

  • owner changed from doki_pen to rjollos.
  • status changed from new to assigned.
  • description changed.

10/15/12 04:53:20 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to duplicate.

10/15/12 04:54:38 changed by rjollos

  • description changed.

11/04/12 23:33:28 changed by hasienda

(In [12304]) TracAnnouncer: Correctly convert id for ticket resources, refs #8065 and #9154.


Add/Change #9154 (ticket deletion error)




Change Properties
Action