Ticket #8697 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Metanav is missing Register and Forgot your password Links with acct_mgr.web_ui.registrationmodule = enabled

Reported by: anonymous Assigned to: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: web_ui login register
Cc: info@modevel.de Trac Release: 0.12

Description (Last modified by rjollos)

Why is the register link not visible.

In the trac.ini, there is set

acct_mgr.web_ui.registrationmodule = enabled

I use ... ubuntu 10.04 LTS + Trac 0.12.2

Thank you ...

Attachments

accountmanagerplugin-metanav-fix.patch (0.9 kB) - added by oxullo@gmail.com on 04/14/11 10:18:17.

Change History

04/13/11 00:25:17 changed by rjollos

  • owner set to hasienda.
  • component changed from SELECT A HACK to AccountManagerPlugin.
  • description changed.

Please set your log level to debug with output to the console and report back if you find any plugin loading errors.

04/13/11 23:50:24 changed by oxullo@gmail.com

Same here, Debian 5.0.8, trac 0.12.2, AccountManager plugin trunk r10079. Exactly the same thing under OSX, tracd-session, same versions as above and a pristine installation:

[components]
acct_mgr.admin.accountguardadminpage = enabled
acct_mgr.admin.accountmanageradminpage = enabled
acct_mgr.api.accountmanager = enabled
acct_mgr.db.sessionstore = enabled
acct_mgr.htfile.abstractpasswordfilestore = enabled
acct_mgr.htfile.htdigeststore = disabled
acct_mgr.htfile.htpasswdstore = enabled
acct_mgr.http.httpauthstore = disabled
acct_mgr.notification.accountchangelistener = enabled
acct_mgr.notification.accountchangenotificationadminpanel = enabled
acct_mgr.pwhash.htdigesthashmethod = disabled
acct_mgr.pwhash.htpasswdhashmethod = enabled
acct_mgr.svnserve.svnservepasswordstore = disabled
acct_mgr.web_ui.accountmodule = enabled
acct_mgr.web_ui.emailverificationmodule = enabled
acct_mgr.web_ui.loginmodule = enabled
acct_mgr.web_ui.registrationmodule = enabled
trac.web.auth.loginmodule = disabled

Debug information yield no errors nor warnings on both envs. The registration link appears under the login form, but not on the metanav.

As soon as:

trac.web.auth.loginmodule = disabled

is commented out, Register and Forgot your password? appear again.

(in reply to: ↑ description ) 04/14/11 01:20:42 changed by hasienda

  • keywords set to web_ui login register.
  • status changed from new to closed.
  • resolution set to duplicate.

Replying to anonymous:

Why is the register link not visible.

Not true, it is, only not in the common place but has been moved conditionally into a new-style login box, if login module is enabled, see #6821 for discussion and development notes, [9577] and [9584] for related changes.

Sorry for any inconvenience. But I made some effort to make it public, at least with clear commit messages, so getting familiar with that embedded documentation while using trunk (=development) code would prevent confusion and save you a lot of time.

Would you like to have the link back? Would you agree to have it in both places, old and new one, configurable? I confess this has been somewhat hidden by late changes of summary for #6821. Discuss there, suggestions welcome. Thanks for testing and taking your time to report back.

(follow-up: ↓ 5 ) 04/14/11 10:17:55 changed by oxullo@gmail.com

  • status changed from closed to reopened.
  • resolution deleted.
  • summary changed from No Register Link visible by acct_mgr.web_ui.registrationmodule = enabled to Metanav is missing Register and Forgot your password Links with acct_mgr.web_ui.registrationmodule = enabled.

Dear hasienda, I think that we were both talking about the missing links on the metanav, not the login form. Please give a look at the attached patch.

04/14/11 10:18:17 changed by oxullo@gmail.com

  • attachment accountmanagerplugin-metanav-fix.patch added.

(in reply to: ↑ 4 ) 04/14/11 20:23:35 changed by hasienda

Replying to oxullo@gmail.com:

Dear hasienda, I think that we were both talking about the missing links on the metanav, not the login form.

Yes, I think I know. Only I tried to explain, that this is connected by the code in question.

Please give a look at the attached patch.

Did it. You try to revert something that was introduced in aforementioned changesets. But did YOU take a look at that references in comment 3? I don't see you've got, that there has been these changes to the development branch resulting in removal of requested metanav links by intention.

I do invite you to move over to what I think is the right place (#6821), where discussion of these changes should happen. By now I only guess you think that this is a regression and should be reverted. Right? But what's so wrong with having the links in the login box? I'd really like to involve you into a design discussion, since at the time when I tried before making the changes no one did take care, and I'm glad this is brought up at least now.

04/14/11 22:33:33 changed by oxullo@gmail.com

  • status changed from reopened to closed.
  • resolution set to fixed.

Dear hasienda, my apologies, I lazily jumped to conclusions as soon as I looked at the changeset. I don't want to make you waste more time on it. I'll keep going on #6821


Add/Change #8697 (Metanav is missing Register and Forgot your password Links with acct_mgr.web_ui.registrationmodule = enabled)




Change Properties
Action