Modify

Opened 4 years ago

Closed 3 years ago

#8723 closed enhancement (fixed)

How to avoid text appearing as an icon?

Reported by: anonymous Owned by: rjollos
Priority: normal Component: EmoticonsPlugin
Severity: normal Keywords:
Cc: mrelbe Trac Release: 0.11

Description

Hi there,

Thanks for this nice plugin.
Is there anyway to inhibit a part of text appearing as an icon?

Cheers,
M

Attachments (0)

Change History (28)

comment:1 Changed 4 years ago by anonymous

Hi,

Is there anyone there ?
Could someone please provide the escape character feature requested?
(Let's say any emoticon sequence prepended by a '!' should display as plain text).

Cheers,
M

comment:2 Changed 4 years ago by rjollos

  • Owner changed from cmlenz to rjollos
  • Status changed from new to assigned

comment:3 Changed 4 years ago by anonymous

Please...
Cheers,
M

comment:4 Changed 4 years ago by anonymous

Hi Ryan,

Thanks for getting involved in this.
Have you already started looking at it?

Cheers,
M

comment:5 Changed 4 years ago by anonymous

Any news ?
Cheers,
M

comment:6 Changed 3 years ago by anonymous

Come one...
Please!
M

comment:7 Changed 3 years ago by rjollos

(In [10400]) Refs #8723: Creating branch for 0.11

comment:8 Changed 3 years ago by rjollos

(In [10401]) Refs #8723: Creating branch for 0.11

comment:9 Changed 3 years ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10404]) Fixes #2502, #8723: Modified the regular expression to allow escaping and to fix issue such that two emoticons would not be matched.

comment:10 Changed 3 years ago by rjollos

(In [10405]) Refs #2502, #8723: Remove print statement accidentally left in code.

comment:11 follow-up: Changed 3 years ago by rjollos

Sorry for the delay! I filter these emails in my inbox and haven't even had time to look at them lately.

Let me know if you have any trouble with the latest version.

Note: There is a new 0.11 branch. The 0.9 branch has not been modified.

comment:12 follow-up: Changed 3 years ago by rjollos

Please let me know if you have any thoughts on #2123 as well.

comment:13 in reply to: ↑ 11 ; follow-up: Changed 3 years ago by anonymous

Thanks Ryan.
Could you please tell us which escape character you chose?
'!' prior to the pattern does not seem to work (string tested = '(KB)') and I don't manage to guess it from the source :-(
Cheers,
Z

comment:14 in reply to: ↑ 12 Changed 3 years ago by anonymous

Replying to rjollos:

Please let me know if you have any thoughts on #2123 as well.

Encapsulating emoticons between brackets to make them pop up as small images seems to me a good idea. People prefering the text version could therefore use it. Also, no more escaping character issue :-)
Cheers,
M

comment:15 in reply to: ↑ 13 ; follow-up: Changed 3 years ago by rjollos

  • Cc mrelbe added; anonymous removed

Replying to anonymous:

Could you please tell us which escape character you chose?
'!' prior to the pattern does not seem to work (string tested = '(KB)') and I don't manage to guess it from the source :-(

I used ! as the escape character. Perhaps the regex has a problem for the particular example you tried. Could you try out some others listed at EmoticonsPlugin#Example?

Would you be willing to try out WikiExtrasPlugin? It has emoticons support, and claims to be able to enable components individually. If that plugin is working well, I'm considering deprecating this one. No sense in duplicating functionality ...

comment:16 in reply to: ↑ 15 ; follow-ups: Changed 3 years ago by anonymous

I used ! as the escape character. Perhaps the regex has a problem for the particular example you tried. Could you try out some others listed at EmoticonsPlugin#Example?


It perfectly works with trac 0.12.2-2 http://bitnami.org/stack/trac :-)
(The problem I had may be due to several factors: someone else installed the plugin for me [correctly?], on an old version of trac (0.11.7) [compliance?], with a load of other packages installed [conflicts?]... This is under investigation...)

Would you be willing to try out WikiExtrasPlugin? It has emoticons support, and claims to be able to enable components individually. If that plugin is working well, I'm considering deprecating this one. No sense in duplicating functionality ...


Unfortunatelly, I cannot manage to make it work on trac 0.12.2-2 http://bitnami.org/stack/trac.
It claims to be installed but does not appear on the "Administation/Manage Plugins" webpage list :-(
Any clue?

Cheers,
M

comment:17 in reply to: ↑ 16 Changed 3 years ago by anonymous

Replying to anonymous:

Unfortunatelly, I cannot manage to make it work on trac 0.12.2-2 http://bitnami.org/stack/trac.
It claims to be installed but does not appear on the "Administration/Manage Plugins" webpage list :-(

Thanks for trying. Please turn on t:TracLogging, set the log level to DEBUG and look for errors loading the WikiExtrasPlugin.

mrelbe maintains that plugin and I've cc'ed him on this ticket. Maybe he will have an idea of what the problem could be.

comment:18 follow-ups: Changed 3 years ago by mtrocme

Thanks for trying. Please turn on t:TracLogging, set the log level to DEBUG and look for errors loading the WikiExtrasPlugin.


Here's the error message I get:

2011-08-05 10:51:35,582 Trac[loader] ERROR: Skipping "tracwikiextras = tracwikiextras": 
Traceback (most recent call last):
  File "build\bdist.win32\egg\trac\loader.py", line 68, in _load_eggs
    entry.load(require=True)
  File "C:\Program Files\BitNami Trac Stack\python\lib\site-packages\setuptools-0.6c11-py2.6.egg\pkg_resources.py", line 1954, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "build\bdist.win32\egg\tracwikiextras\__init__.py", line 1, in <module>
  File "build\bdist.win32\egg\tracwikiextras\boxes.py", line 28, in <module>
  File "build\bdist.win32\egg\tracwikiextras\icons.py", line 55, in <module>
ImportError: cannot import name ConfigSection

As I understand it, the ConfigSection module is not included in the .egg provided by Bitnami (Trac-0.12.2-py2.6.egg).
If that's correct, is there anything I can do to fix this?
Also some mimeview stuff are missing (Pygments, docutils, SilverCity and textile). Should I try to install them?

Cheers,
M

comment:19 in reply to: ↑ 18 ; follow-up: Changed 3 years ago by rjollos

Replying to mtrocme:

As I understand it, the ConfigSection module is not included in the .egg provided by Bitnami (Trac-0.12.2-py2.6.egg).
If that's correct, is there anything I can do to fix this?

It looks like you are right. I don't see ConfigSection in Trac-0.12-stable. I reported your issue in #9073. Unless the plugin author wants to support Trac 0.12 or you wish to develop a patch yourself, you won't be able to use that plugin.

It looks like we are headed back to making the EmoticonsPlugin work for your installation. Could you try the tests I suggested in comment:15?

comment:20 in reply to: ↑ 18 ; follow-up: Changed 3 years ago by rjollos

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to mtrocme:

Also some mimeview stuff are missing (Pygments, docutils, SilverCity and textile). Should I try to install them?

  • You won't need t:SilverCity unless you are trying to use an early plugin that doesn't support Genshi. Most likely you won't need it.
  • Pygments is suggested if you want to get nicer syntax highlighting in the repository browser. See t:TracSyntaxColoring.
  • I'm not sure about the other two, I have them installed but I'm not sure if they are utilized by any of the components. The safe bet would be to just go ahead and install them.

comment:21 in reply to: ↑ 19 Changed 3 years ago by anonymous

...or you wish to develop a patch yourself, you won't be able to use that plugin.


Unfortunately, I'm not skilled enough to do that for the time being.

It looks like we are headed back to making the EmoticonsPlugin work for your installation. Could you try the tests I suggested in comment:15?


I tested all of them last time. All worked perfectly :-)
Thanks Ryan

comment:22 in reply to: ↑ 20 ; follow-up: Changed 3 years ago by anonymous

Cheers,
CU around,
M

comment:23 in reply to: ↑ 22 Changed 3 years ago by mtrocme

Just to let you know, I ran all the examples on a older bitnami trac stack, namely Trac-0.11.6-py2.5.egg.
All works perfectly :-)
Cheers,
M

comment:24 follow-up: Changed 3 years ago by rjollos

Thanks for reporting back. I've tagged the EmoticonsPlugin wiki page with 0.11 and 0.12. Is there anything else to do for this ticket, or can I go ahead and close it?

comment:25 in reply to: ↑ 24 ; follow-up: Changed 3 years ago by anonymous

The investigations discussed in comment:16 are still underway (by someone else).
Thanks for waiting a few days more.
Cheers,
Mathieu

comment:26 in reply to: ↑ 16 Changed 3 years ago by mrelbe

Replying to anonymous:

Would you be willing to try out WikiExtrasPlugin? It has emoticons support, and claims to be able to enable components individually. If that plugin is working well, I'm considering deprecating this one. No sense in duplicating functionality ...


Unfortunatelly, I cannot manage to make it work on trac 0.12.2-2 http://bitnami.org/stack/trac.
It claims to be installed but does not appear on the "Administation/Manage Plugins" webpage list :-(
Any clue?

The WikiExtrasPlugin is currently not targeted for Trac 0.12 (however, this restriction has not been defined appropriately, see #9073) reason being that some styling of Trac 0.13 will change, which this plugin enhances (e.g. using the boxes in WikiExtrasPlugin will probably look inconsistent with built in boxes in Trac 0.12 such as table of contents).

Much of the code behind WikiExtrasPlugin is based on the WikiGoodiesPlugin, why I involved Christian in creating this, who in turn suggested that WikiExtrasPlugin perhaps should be integrated as an option in the core of Trac 0.13 (one of the problems that has to be solved is how to distribute the vast icon library in that case). The "release" of WikiExtrasPlugin was therefore made to get a feeling of what others think of it. I therefore didn't intend to make it 0.12-compatible, but if it turns out that many users would like a 0.12-variant of WikiExtrasPlugin, perhaps I could do that.

comment:27 in reply to: ↑ 25 Changed 3 years ago by anonymous

The investigations discussed in comment:16 are still underway (by someone else).
Thanks for waiting a few days more.


Everything's fine :-))

Cheers Ryan,
CU around,
Mathieu

comment:28 Changed 3 years ago by rjollos

  • Resolution set to fixed
  • Status changed from reopened to closed

Thanks for reporting back. Glad it is working well for you!

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.