Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#9006 closed enhancement (fixed)

Format closed tasks in task list (left hand pane) so that they are readily distiguished from open tasks

Reported by: rjollos Owned by: ChrisNelson
Priority: normal Component: TracJsGanttPlugin
Severity: normal Keywords:
Cc: bof Trac Release: 0.11

Description

I'd find it useful to be able to readily distinguish open from closed tasks in the left hand pane. One simple idea I had was to use Trac's strike-through notation for closed tickets (e.g. #1002). Or perhaps strike-through for the whole task.


Other obvious options would be background or font coloring. Use bold font for open tickets?

My concern about the background coloring is that it might interfere with existing and proposed (#8987) background coloring

Does anyone else have a suggestion on how to best implement this feature?

Attachments (1)

StrikethroughClosedTasks.png (18.5 KB) - added by rjollos 3 years ago.

Download all attachments as: .zip

Change History (11)

Changed 3 years ago by rjollos

comment:1 follow-up: Changed 3 years ago by ChrisNelson

Following Trac style with strike through seems a good solution to me. I've had this on my mental To Do list for a while. My problem is how do I get Python to influence the style used by the JavaScript which builds the list without making jsGantt Trac-specific.

comment:2 in reply to: ↑ 1 Changed 3 years ago by rjollos

Replying to ChrisNelson:

Following Trac style with strike through seems a good solution to me.

I think you are right. More specifically, I tend to prefer strike-through of the whole task (ticket # and summary) rather than just the ticket number.

comment:3 Changed 3 years ago by anonymous

  • Owner changed from ChrisNelson to anonymous
  • Status changed from new to assigned

comment:4 Changed 3 years ago by ChrisNelson

  • Owner changed from anonymous to ChrisNelson
  • Status changed from assigned to new

comment:5 Changed 3 years ago by ChrisNelson

(In [10578]) Style task name. Refs #9006.

  • Color background of task name span on left like task bar on right.
  • Strike through name of closed tasks.

Changes to jsgantt.js just aply the passed class to the task name (it
was previously only on the task bar in the Gantt).

Change to tracjsgantt.py pass closed class when appropriate.

Change to tracjsgantt.css create span (name) and dif (task) styles.

The left text alignment is needed because this change adds gtask class
to the task name. I may come back and fix that but this works.

comment:6 Changed 3 years ago by ChrisNelson

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 follow-up: Changed 3 years ago by rjollos

There is some related discussion in th:comment:8:ticket:9981 that you may be interested in.

These changes look really good. Thanks for implementing this!

comment:8 in reply to: ↑ 7 ; follow-up: Changed 3 years ago by ChrisNelson

Replying to rjollos:

There is some related discussion in t:comment:8:ticket:9981 that you may be interested in.

Yes, interesting. I'd be strongly against a red background because that's use in ticket reports for critical issues. Whatever the community decides, TracJSGantt implements this in one line of CSS so it's easy to change (or for a user to do their own thing with).

These changes look really good. Thanks for implementing this!

You're welcome. It makes my life easier, too!

comment:9 in reply to: ↑ 8 Changed 3 years ago by rjollos

Replying to ChrisNelson:

Yes, interesting. I'd be strongly against a red background because that's use in ticket reports for critical issues. Whatever the community decides, TracJSGantt implements this in one line of CSS so it's easy to change (or for a user to do their own thing with).

That's a good point and probably worth adding to the discussion in that thread. So far none of the alternatives seem significantly better than the strike-through, IMO.

comment:10 Changed 3 years ago by ChrisNelson

(In [10580]) Clean up JS to allow simpler CSS. Refs #9006.

Don't add "gtask" to list of classes returned by getClass(). Add it
explicitly only where needed.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.