Scheduling logic redesign

[dinu]

I made a change for the scheduling logic to make it useful for real world planning. The planned start and end fields should be authoritative: I may know that the person the bug is assigned to only works half-time, or also has other tasks, or is going away for a number of days. So a 2-hour ticket may be planned to 2 days. Redesigned the logic to only compute start and finish if not specified.

[Chris Nelson]

(In [10904]) Honor user-specified start and finish date. Refs #9515.

This seems useful in some cases and harmless in others. I tested with an 8-hour task with 2 hours done and a week between start and finish and it showed 25% of the task filled in.

Based on a patch from dinumarina. Thanks.

[Chris Nelson]

(In [11069]) Handle implicit dates in parent tickets. Refs #9042, #9515.

Need to carry around an indication of whether the date is implicit or explicit.

[Chris Nelson]

(In [11071]) Refactor PM stuff out of Gantt class. Refs #9024, #9515, #8982.

[Chris Nelson]

(In [11072]) Refactor scheduling out of PM class. Refs #8982, #9042, #9515.

[Chris Nelson]

(In [11073]) Move Project Management stuff into its own module. Refs #8982, #9042, #9515.

[Chris Nelson]

(In [11074]) Make successor, predecessors consistent with parent, children. Refs #9042, #9515.

predecessors() and successors() returned lists of strings (e.g., ['123', '234']) but parent() returns an integer and children() returns a list of integers. Now all handle integers.

[Chris Nelson]

(In [11076]) Clean up start and finish handling. Refs #9042, #9515.

• Refactor start and finish parse routines to set time to midnight.

• Don't set time to midnight in values returned from parse routines.

• When defaulting to today, set time to midnight (including seconds, useconds)

[Chris Nelson]

(In [11077]) Rename percent() to percentComplete() for clarity. Refs #9042, #9515.

Some other refactoring of percent complete calculations.

[Chris Nelson]

(In [11079]) Cleaner date adjustment using calendarOffset. Refs #9533, #9300, #9042, #9515.

Scheduler used to assume work week. Now let calendarOffset() do that.

Also, it seems rounding errors would creep in and some datetimes would have non-zero microseconds. This tests for beginning and end of day with a little delta.

[Chris Nelson]

(In [11081]) Copy some dates before returning them. Refs #9042, #9515, #9533, #9300.

I'm not 100% sure why this is necessary but the wrong things seemed to get updated if I didn't do this and give demonstrably wrong results.

[Chris Nelson]

(In [11084]) Handle explicit finish with implicit start in ASAP schedule. Refs #9042, #9515.

And vice versa in ALAP.

Also removed unnecessary fixup of explicit start; parseStart() already zeros out those values.

[dinu]

Could you remove my email please; seems it's getting crawled :) Thanks

[Chris Nelson]

Replying to dinu:

Could you remove my email please; seems it's getting crawled :) Thanks

Regrettably, I don't have permission to do that. Ryan -- who is Cc'd on this ticket -- knows people, perhaps he can pass the word.

[Ryan J Ollos]

I could delete the patch and comments by dinu, but I don't see a way I can change the Reporter field without having a comment that shows the old and new Reporter's name, thereby leaving the email address in the ticket.

I'll have full admin permissions on t-h.o soon, and then might be able to fix the issue by direct database edit.

[anonymous]

Ask osimons on IRC... he knows a secret guy with admin permissions who can edit the database directly...

A friend

[Chris Nelson]

This seems to be working now.