Modify

Opened 3 years ago

Closed 3 years ago

#9515 closed enhancement (fixed)

Scheduling logic redesign

Reported by: dinu Owned by: ChrisNelson
Priority: normal Component: TracJsGanttPlugin
Severity: normal Keywords:
Cc: rjollos, falkb Trac Release: 0.12

Description

I made a change for the scheduling logic to make it useful for real world planning. The planned start and end fields should be authoritative: I may know that the person the bug is assigned to only works half-time, or also has other tasks, or is going away for a number of days. So a 2-hour ticket may be planned to 2 days. Redesigned the logic to only compute start and finish if not specified.

Attachments (1)

schedulingLogic.patch (3.0 KB) - added by dinumarina@… 3 years ago.

Download all attachments as: .zip

Change History (23)

Changed 3 years ago by dinumarina@…

comment:1 Changed 3 years ago by rjollos

  • Cc rjollos added; anonymous removed

comment:2 Changed 3 years ago by falkb

  • Cc falkb added

comment:3 Changed 3 years ago by anonymous

  • Owner changed from ChrisNelson to anonymous
  • Status changed from new to assigned

comment:4 Changed 3 years ago by ChrisNelson

  • Owner changed from anonymous to ChrisNelson
  • Status changed from assigned to new

comment:5 Changed 3 years ago by ChrisNelson

(In [10904]) Honor user-specified start and finish date. Refs #9515.

This seems useful in some cases and harmless in others. I tested with an 8-hour task with 2 hours done and a week between start and finish and it showed 25% of the task filled in.

Based on a patch from dinumarina. Thanks.

comment:6 Changed 3 years ago by ChrisNelson

  • Status changed from new to assigned

comment:7 Changed 3 years ago by ChrisNelson

(In [11069]) Handle implicit dates in parent tickets. Refs #9042, #9515.

Need to carry around an indication of whether the date is implicit or explicit.

comment:8 Changed 3 years ago by ChrisNelson

(In [11071]) Refactor PM stuff out of Gantt class. Refs #9024, #9515, #8982.

comment:9 Changed 3 years ago by ChrisNelson

(In [11072]) Refactor scheduling out of PM class. Refs #8982, #9042, #9515.

comment:10 Changed 3 years ago by ChrisNelson

(In [11073]) Move Project Management stuff into its own module. Refs #8982, #9042, #9515.

comment:11 Changed 3 years ago by ChrisNelson

(In [11074]) Make successor, predecessors consistent with parent, children. Refs #9042, #9515.

predecessors() and successors() returned lists of strings (e.g., ['123', '234']) but parent() returns an integer and children() returns a list of integers. Now all handle integers.

comment:12 Changed 3 years ago by ChrisNelson

(In [11076]) Clean up start and finish handling. Refs #9042, #9515.

  • Refactor start and finish parse routines to set time to midnight.
  • Don't set time to midnight in values returned from parse routines.
  • When defaulting to today, set time to midnight (including seconds, useconds)

comment:13 Changed 3 years ago by ChrisNelson

(In [11077]) Rename percent() to percentComplete() for clarity. Refs #9042, #9515.

Some other refactoring of percent complete calculations.

comment:14 Changed 3 years ago by ChrisNelson

(In [11079]) Cleaner date adjustment using calendarOffset. Refs #9533, #9300, #9042, #9515.

Scheduler used to assume work week. Now let calendarOffset() do that.

Also, it seems rounding errors would creep in and some datetimes would have non-zero microseconds. This tests for beginning and end of day with a little delta.

comment:15 Changed 3 years ago by ChrisNelson

(In [11081]) Copy some dates before returning them. Refs #9042, #9515, #9533, #9300.

I'm not 100% sure why this is necessary but the wrong things seemed to get updated if I didn't do this and give demonstrably wrong results.

comment:16 Changed 3 years ago by ChrisNelson

(In [11084]) Handle explicit finish with implicit start in ASAP schedule. Refs #9042, #9515.

And vice versa in ALAP.

Also removed unnecessary fixup of explicit start; parseStart() already zeros out those values.

comment:17 follow-up: Changed 3 years ago by dinu

Could you remove my email please; seems it's getting crawled :) Thanks

comment:18 in reply to: ↑ 17 Changed 3 years ago by ChrisNelson

Replying to dinu:

Could you remove my email please; seems it's getting crawled :) Thanks

Regrettably, I don't have permission to do that. Ryan -- who is Cc'd on this ticket -- knows people, perhaps he can pass the word.

comment:19 Changed 3 years ago by rjollos

  • Reporter changed from dinumarina@… to dinu

comment:20 follow-up: Changed 3 years ago by rjollos

I could delete the patch and comments by dinu, but I don't see a way I can change the Reporter field without having a comment that shows the old and new Reporter's name, thereby leaving the email address in the ticket.

I'll have full admin permissions on t-h.o soon, and then might be able to fix the issue by direct database edit.

comment:21 in reply to: ↑ 20 Changed 3 years ago by anonymous

Ask osimons on IRC... he knows a secret guy with admin permissions who can edit the database directly...

A friend

comment:22 Changed 3 years ago by ChrisNelson

  • Resolution set to fixed
  • Status changed from assigned to closed

This seems to be working now.

Add Comment

Modify Ticket

Action
as closed The owner will remain ChrisNelson.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.