Wrong ticket url?

[Krzysztof Antczak]

I can't tell You why, but it seems, that ticket url is generated in incorrect way - it redirects me into '/ticket/7' instead of '/env/project/ticket/7'

[Krzysztof Antczak]

Replying to Krzysztof Antczak:

I can't tell You why, but it seems, that ticket url is generated in incorrect way - it redirects me into '/ticket/7' instead of '/env/project/ticket/7'

Oh, and i'm testing it under trac 0.13-dev, some css styling results, looks a little bit different here.

Ticket comment: ​http://i.imm.io/pH2c.png

vs yours: ticket1.png:wiki:CodeReviewerPlugin​

Hm, first comment looks totally different, why?

[Rob Guttman]

Oh, and i'm testing it under trac 0.13-dev, some css styling results, looks a little bit different here.

Ticket comment: ​http://i.imm.io/pH2c.png

vs yours: ticket1.png:wiki:CodeReviewerPlugin​

Hm, first comment looks totally different, why?

Krzysztof, the first comment you see in my screenshot is from using the provided CommitTicketReferenceMacro - see configuration instructions here.

I think I see what's up with your main issue above - testing a fix now..

[Rob Guttman]

(In [11575]) refs #10034: ticket url fix.

[Krzysztof Antczak]

Updated, tested, works fine ;-)

PS. i still can't force this 'passed' status to looks like yours:

coderev.* = enabled tracopt.ticket.commit_updater.committicketupdater = disabled tracopt.ticket.commit_updater.committicketreferencemacro = enabled

is it correct?

[Rob Guttman]

Replying to Krzysztof Antczak:

Updated, tested, works fine ;-)

Great.

PS. i still can't force this 'passed' status to looks like yours:

coderev.* = enabled tracopt.ticket.commit_updater.committicketupdater = disabled tracopt.ticket.commit_updater.committicketreferencemacro = enabled

is it correct?

That looks correct. But note that we're talking about two different comments here:

1. the original changeset comment
2. review comments

The CommitTicketReferenceMacro only impacts the first type of comment - i.e., the original changeset comment. For that to work, the commit_updater must be used and you need to have your repo hooks configured to call the appropriate trac-admin command to make sure the changeset gets associated with the ticket and then therefore creates the original changeset comment. More details can be found ​here and ​here.

I believe the original issue above has been resolved and so am going to close this ticket. If you still have issues with the macro after reviewing the above links, please open a new ticket for that. Thanks.