Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#10156 closed defect (fixed)

DefaultCC plugin doesn't work with Release 1.0

Reported by: oliver.staron@… Owned by: Ryan J Ollos
Priority: normal Component: DefaultCcPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description (last modified by Ryan J Ollos)

2012-07-17 17:09:50,723 Trac[env] ERROR: Exception caught while checking for upgrade: 
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/env.py", line 819, in open_environment
    needs_upgrade = env.needs_upgrade()
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/env.py", line 655, in needs_upgrade
    if participant.environment_needs_upgrade(db):
  File "build/bdist.linux-x86_64/egg/defaultcc/admin.py", line 59, in environment_needs_upgrade
    db.rollback()
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/db/util.py", line 107, in __getattr__
    raise AttributeError
AttributeError: 
2012-07-17 17:09:58,509 Trac[main] ERROR: Internal Server Error: 
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/web/main.py", line 490, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/web/main.py", line 224, in dispatch
    content_type)
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/web/chrome.py", line 995, in render_template
    stream |= self._filter_stream(req, method, filename, stream, data)
  File "/usr/lib/python2.7/site-packages/genshi/core.py", line 132, in __or__
    return Stream(_ensure(function(self)), serializer=self.serializer)
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/web/chrome.py", line 1176, in inner
    data)
  File "build/bdist.linux-x86_64/egg/defaultcc/admin.py", line 109, in filter_stream
    default_ccs = DefaultCC.select(self.env)
  File "build/bdist.linux-x86_64/egg/defaultcc/model.py", line 83, in select
    cursor.execute("SELECT name,cc FROM component_default_cc "
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/db/util.py", line 66, in execute
    return self.cursor.execute(sql)
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/db/sqlite_backend.py", line 78, in execute
    result = PyFormatCursor.execute(self, *args)
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/db/sqlite_backend.py", line 56, in execute
    args or [])
  File "/usr/local/lib/python2.7/site-packages/Trac-1.0dev_r11123-py2.7.egg/trac/db/sqlite_backend.py", line 48, in _rollback_on_error
    return function(self, *args, **kwargs)
OperationalError: no such table: component_default_cc

Attachments (0)

Change History (12)

comment:1 Changed 5 years ago by oliver.staron@…

sorry, used wrong email-address.

comment:2 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:3 Changed 5 years ago by Ryan J Ollos

Owner: changed from jeangui to Ryan J Ollos

comment:4 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

(In [11734]) Fixes #9555, #10156:

  • FIX: Traceback would occur when a system_message is raised, which could be due to component with same name already existing or 'Remove selected items' pressed with no items selected. Thanks to nike-17@… for the report.
  • FIX: Package was missing __init__.py file, which could result in a failure of the plugin to load.
  • FIX: Removed rollbacks on db upgrade, which fail in Trac 1.0dev and later since the db connection is read-only.

comment:5 Changed 5 years ago by Ryan J Ollos

[11735] should have referenced this ticket. The post-commit hook here apparently doesn't like the colon after the keyword.

(In [11735]) Refs: #9555, #10156: Reverted unintended change in [11734].

comment:6 Changed 5 years ago by oliver.staron@…

wow, that was quick! It works!

Thank you very much!

comment:7 Changed 5 years ago by Ryan J Ollos

Thanks for testing! Let us know if you find any other issues. I'm not using the plugin myself, but just saw that it was an easy one to fixup.

comment:8 Changed 5 years ago by Ryan J Ollos

I decided to make a couple more changes to the plugin. I'll CC you on this tickets in case you have an interest in trying out a newer version.

comment:9 Changed 5 years ago by anonymous

Fine, I'll test it, as soon I get something from you. Could you please correct my email-Address to oliver.staron@…?

comment:11 in reply to:  9 Changed 5 years ago by Ryan J Ollos

Reporter: changed from o.staron@… to oliver.staron@…

Replying to anonymous:

Fine, I'll test it, as soon I get something from you. Could you please correct my email-Address to oliver.staron@…?

Sure, done. I cc'ed you on the ticket where I've made some changes. There were a couple of other miscellaneous changes as well, which can be seen at DefaultCcPlugin#RecentChanges.

I'm considering doing more later on, but not sure if I'll find the time yet.

comment:11 Changed 4 years ago by Ryan J Ollos

(In [12022]) Refs #9555, #10156: Tagging version 0.2

comment:12 Changed 4 years ago by Ryan J Ollos

(In [12023]) Refs #9555, #10156: Tagging version 0.1

Modify Ticket

Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.