Logic on the settings page is backwards...

[branson]

Is:

 if req.args.get('enabled'):
                    req.session[self.session_field] = 'False'

should be :

 if not req.args.get('enabled'):
                    req.session[self.session_field] = 'False'

[Ryan J Ollos]

Is this plugin still maintained?

[anonymous]

yer about to do it to me again aren't you .. ;-) .. I'll submit ticket and mail...

[Ryan J Ollos]

Well, if you keeping fixing bugs at the rate you have been, then you're asking for it ;)

[kostialopuhin]

Hmm looks really strange. If you change it, you also should change the previous line, so the whole change would be:

from

51     req.session[self.session_field] = 'True'
52     if req.args.get('enabled'):
53         req.session[self.session_field] = 'False'

to

51     req.session[self.session_field] = str(bool(req.args.get('enabled', False))

but you should test)

I think I just copied that code from some example, and maybe made some mistakes along the way, don't remember writing it ;)

As for another part - I will answer in #10187

[Ryan J Ollos]

Appears to be fixed in [11838].