Modify

Opened 5 years ago

Closed 5 years ago

#10231 closed defect (fixed)

Slash in Milestone name prevents displaying dependency graph

Reported by: Olaf Mandel Owned by: Ryan J Ollos
Priority: low Component: MasterTicketsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Description

When viewing a milestone with a forward slash ("/") in its name and a few tickets with dependencies, the link "Depgraph" in the upper right corner is shown correctly. But the linked page contains only an empty image without content.

Anlysis

It seems that when parsing the URL, only the part of the Milestone name up until the first forward slash is taken as the ticket milestone, resulting in an empty list of tickets.

E.g. for a milestone called "GUI/HW separation", I see this query like this in the log file:

SELECT t.id AS id,t.summary AS summary,t.owner AS owner,t.type AS type,
t.status AS status,t.priority AS priority,t.component AS component,
t.time AS time,t.changetime AS changetime,t.milestone AS milestone,
priority.value AS priority_value
FROM ticket AS t LEFT OUTER JOIN enum AS priority
ON (priority.type='priority' AND priority.name=priority)
WHERE ((COALESCE(t.milestone,'')='GUI'));

Note that the 'GUI' in the WHERE clause should have been 'GUI/HW separation'

Note

I use the distributor supplied version of this plugin, but I had a look at the diff between that and the "official" download: https://github.com/coderanger/trac-mastertickets/tarball/master . The differences are minimal and do not seem to include changes to the URL parsing.

Attachments (0)

Change History (4)

comment:1 in reply to:  description ; Changed 5 years ago by Ryan J Ollos

Replying to omandel:

[...]

I use the distributor supplied version of this plugin, but I had a look at the diff between that and the "official" download: https://github.com/coderanger/trac-mastertickets/tarball/master . The differences are minimal and do not seem to include changes to the URL parsing.

Just curious, who is the distributor?

comment:2 in reply to:  1 Changed 5 years ago by Olaf Mandel

Replying to rjollos:

Replying to omandel:

[ ... ]

I use the distributor supplied version of this plugin, but I had a look at the diff between that and the "official" download: [ they ] are minimal and do not seem to include changes to the URL parsing.

Just curious, who is the distributor?

Fedora. The specific distribution is Fedora 17 Desktop 64-bit.

comment:3 Changed 5 years ago by Ryan J Ollos

Owner: changed from Noah Kantrowitz to Ryan J Ollos
Status: newassigned

comment:4 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.