Opened 12 years ago
Closed 7 years ago
#10326 closed enhancement (fixed)
Make compatible with Trac 1.0
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Component: | BacklogPlugin |
Severity: | normal | Keywords: | database cursor scope |
Cc: | Anna Nachesa, Bart Ogryczak | Trac Release: | 1.0 |
Description (last modified by )
Implement changes to make the plugin compatible with Trac 0.12 through 1.0.
Attachments (1)
Change History (13)
comment:1 Changed 12 years ago by
Status: | new → assigned |
---|
Changed 12 years ago by
Attachment: | ErrorInThemeTemplate.png added |
---|
comment:3 Changed 12 years ago by
(In [11996]) Refs #8653, #10326 (0.1.34) Numerous fixes for compatibility with Trac 0.12 and 1.0:
- Fix for possible cannot operate on closed cursor error. The
db
object could be cleaned up before the cursor is used in thetry/catch
. This does not seem to happen if thedb
object is passed as a parameter though, so the_create_ordering_table
function was changed from a private member function of theBacklogModule
class, to a private function of theweb_ui
module. - Assignments were made to the following variables for no apparent reason, as they were not being used:
data['req']
anddata['args']
. The assignmentdata['req']
was causing problems as it was overwriting thereq
object in the template space, leading to a traceback, but only under Trac 1.0 (ticket/10326). - The
unique
attribute of aColumn
was removed in Trac 0.12, and a traceback was resulting from its use (ticket/10326). The attribute actually had no effect in Trac 0.11 anyway ([t 9406/trunk/trac/db/schema.py]). - The
env
member variable of theBacklogList
class was being used, but was never assigned, resulting in a traceback (ticket/8653).
comment:4 Changed 12 years ago by
comment:7 Changed 12 years ago by
Keywords: | database cursor scope added |
---|
comment:8 follow-up: 10 Changed 12 years ago by
We now have full compatibility with Trac 0.12 and 1.0, with the exception of a timestamp vs utimestamp issue, which was brought up and will be addressed in #8653.
Please comment in this ticket if you've had the opportunity to test. I'll leave this ticket open for a while and eventually bump the plugin version to 0.2.0.
comment:9 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Type: | task → enhancement |
I'm not sure why [11999] shows just 4 of the several existing files being copied in addition to the move on backlogplugin/0.11
. It seems like a bug in Trac or SVN.
comment:10 Changed 12 years ago by
comment:11 Changed 11 years ago by
Status: | assigned → new |
---|
Here is one issue, which I'll commit a fix for shortly: