Modify

Opened 5 years ago

Closed 3 weeks ago

#10326 closed enhancement (fixed)

Make compatible with Trac 1.0

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: BacklogPlugin
Severity: normal Keywords: database cursor scope
Cc: Anna Nachesa, Bart Ogryczak Trac Release: 1.0

Description (last modified by Ryan J Ollos)

Implement changes to make the plugin compatible with Trac 0.12 through 1.0.

Attachments (1)

ErrorInThemeTemplate.png (49.2 KB) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by Ryan J Ollos

Status: newassigned

Here is one issue, which I'll commit a fix for shortly:

01:21:05 PM Trac[loader] ERROR: Skipping "backlog.db = backlog.db": 
Traceback (most recent call last):
  File "/home/user/Workspace/th8653/trac-trunk/trac/loader.py", line 68, in _load_eggs
    entry.load(require=True)
  File "/home/user/Workspace/th8653/lib/python2.6/site-packages/distribute-0.6.14-py2.6.egg/pkg_resources.py", line 1954, in load
    entry = __import__(self.module_name, globals(),globals(), ['__name__'])
  File "/home/user/Workspace/backlogplugin/0.11/backlog/db.py", line 21, in <module>
    Column('name',unique=True),
TypeError: __init__() got an unexpected keyword argument 'unique'

Changed 5 years ago by Ryan J Ollos

Attachment: ErrorInThemeTemplate.png added

comment:2 Changed 5 years ago by Ryan J Ollos

Here is another error that will be fixed shortly:

comment:3 Changed 5 years ago by Ryan J Ollos

(In [11996]) Refs #8653, #10326 (0.1.34) Numerous fixes for compatibility with Trac 0.12 and 1.0:

  • Fix for possible cannot operate on closed cursor error. The db object could be cleaned up before the cursor is used in the try/catch. This does not seem to happen if the db object is passed as a parameter though, so the _create_ordering_table function was changed from a private member function of the BacklogModule class, to a private function of the web_ui module.
  • Assignments were made to the following variables for no apparent reason, as they were not being used: data['req'] and data['args']. The assignment data['req'] was causing problems as it was overwriting the req object in the template space, leading to a traceback, but only under Trac 1.0 (ticket/10326).
  • The unique attribute of a Column was removed in Trac 0.12, and a traceback was resulting from its use (ticket/10326). The attribute actually had no effect in Trac 0.11 anyway ([t 9406/trunk/trac/db/schema.py]).
  • The env member variable of the BacklogListclass was being used, but was never assigned, resulting in a traceback (ticket/8653).

comment:4 Changed 5 years ago by Ryan J Ollos

(In [11997]) Refs #10326: Code style change, that will also help with clarity when debugging: Changed the chrome-relative path for javascript and stylesheets from bl to backlog.

comment:5 Changed 5 years ago by Ryan J Ollos

(In [11998]) Refs #10326: (0.1.35) Part of [11997].

comment:6 Changed 5 years ago by Ryan J Ollos

(In [11999]) Refs #10326: Renamed 0.11 directory to trunk.

comment:7 Changed 5 years ago by Ryan J Ollos

Keywords: database cursor scope added

comment:8 Changed 5 years ago by Ryan J Ollos

We now have full compatibility with Trac 0.12 and 1.0, with the exception of a timestamp vs utimestamp issue, which was brought up and will be addressed in #8653.

Please comment in this ticket if you've had the opportunity to test. I'll leave this ticket open for a while and eventually bump the plugin version to 0.2.0.

comment:9 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)
Type: taskenhancement

I'm not sure why [11999] shows just 4 of the several existing files being copied in addition to the move on backlogplugin/0.11. It seems like a bug in Trac or SVN.

comment:10 in reply to:  8 Changed 5 years ago by Ryan J Ollos

Replying to rjollos:

We now have full compatibility with Trac 0.12 and 1.0, with the exception of a timestamp vs utimestamp issue, which was brought up and will be addressed in #8653.

This issue was addressed in #10330.

comment:11 Changed 4 years ago by Ryan J Ollos

Status: assignednew

comment:12 Changed 3 weeks ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

Delegating to #13274.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.