Modify

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#10423 closed defect (fixed)

Uses schema versions instead of ugly db table existence test

Reported by: Steffen Hoffmann Owned by: Ryan J Ollos
Priority: normal Component: WatchlistPlugin
Severity: major Keywords: AttributeError upgrade db
Cc: Ryan J Ollos Trac Release: 1.0

Description

Plugin's schema version check relies on a depreciated way of plugin db schema version checking. It risks exceptions on execution of the SELECT SQL statement in absence of the corresponding db table in tracwatchlist.db.settings_table_exists.

The issue has been discussed for Trac in t:#10451, after raised for TagsPlugin in #9521.

A working solutions was implemented in [10800:12077], but this is still WiP (see https://groups.google.com/d/topic/trac-dev/jL0LbLvEl-M/discussion as well).

Fixing this will be critical for Trac-1.0 compatibility.

Attachments (0)

Change History (4)

comment:1 Changed 5 years ago by Steffen Hoffmann

Cc: Ryan J Ollos added; anonymous removed

I'll have a closer look when working on AnnouncerPlugin again. Feel free to contact me earlier for discussion as needed.

comment:2 Changed 3 years ago by Ryan J Ollos

Owner: changed from Martin Scharrer to Ryan J Ollos
Status: newaccepted

comment:3 Changed 3 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 14022:

Fix test for table existence in Trac 1.0 and later. Fixes #10423.

comment:4 Changed 3 years ago by Steffen Hoffmann

Looks good, thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.