Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#10423 closed defect (fixed)

Uses schema versions instead of ugly db table existence test

Reported by: hasienda Owned by: rjollos
Priority: normal Component: WatchlistPlugin
Severity: major Keywords: AttributeError upgrade db
Cc: rjollos Trac Release: 1.0


Plugin's schema version check relies on a depreciated way of plugin db schema version checking. It risks exceptions on execution of the SELECT SQL statement in absence of the corresponding db table in tracwatchlist.db.settings_table_exists.

The issue has been discussed for Trac in t:#10451, after raised for TagsPlugin in #9521.

A working solutions was implemented in [10800:12077], but this is still WiP (see as well).

Fixing this will be critical for Trac-1.0 compatibility.

Attachments (0)

Change History (4)

comment:1 Changed 4 years ago by hasienda

  • Cc rjollos added; anonymous removed

I'll have a closer look when working on AnnouncerPlugin again. Feel free to contact me earlier for discussion as needed.

comment:2 Changed 2 years ago by rjollos

  • Owner changed from martin_s to rjollos
  • Status changed from new to accepted

comment:3 Changed 2 years ago by rjollos

  • Resolution set to fixed
  • Status changed from accepted to closed

In 14022:

Fix test for table existence in Trac 1.0 and later. Fixes #10423.

comment:4 Changed 2 years ago by hasienda

Looks good, thanks.

Add Comment

Modify Ticket

as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.