Modify

Opened 5 years ago

Closed 10 months ago

Last modified 10 months ago

#10531 closed enhancement (fixed)

Add CHILDTICKETS_ADMIN permission

Reported by: Sergio Talens-Oliag Owned by: Sergio Talens-Oliag
Priority: normal Component: ChildTicketsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

I've patched your plugin to include a new admin permission different than TRAC_ADMIN; I've done it because I want some users to be project managers and be able to customize the trac projects (i.e., adjust the settings of this plugin) but don't want to give them TRAC_ADMIN permission.

Attachments (2)

childticketsplugin-admin_perm.patch (1.8 KB) - added by Sergio Talens-Oliag 5 years ago.
CHILDTICKETS_ADMIN patch
childticketsplugin-ticket_admin_perm.patch (1.8 KB) - added by Sergio Talens-Oliag 5 years ago.
Add TICKET_ADMIN permission patch

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by Sergio Talens-Oliag

CHILDTICKETS_ADMIN patch

comment:1 Changed 5 years ago by Ryan J Ollos

Why not just use TICKET_ADMIN?

comment:2 in reply to:  1 Changed 5 years ago by Sergio Talens-Oliag

Replying to rjollos:

Why not just use TICKET_ADMIN?

Because I did it too fast, you are absolutely right, TICKET_ADMIN is the right permission to use.

I'll upload a new patch.

Changed 5 years ago by Sergio Talens-Oliag

Add TICKET_ADMIN permission patch

comment:3 Changed 5 years ago by Ryan J Ollos

+1 for this change. I think the approach of allowing users with TICKET_ADMIN to access the panel makes sense, since TICKET_ADMIN grants access to the other ticket admin panels.

comment:4 Changed 4 years ago by Jared

Where does one apply this patch?

comment:5 Changed 4 years ago by Ryan J Ollos

Btw, the patch is okay, except that you don't need to implement (and shouldn't implement) the IPermissionRequestor interface.

walnut: any chance to apply this soon?

comment:6 in reply to:  4 Changed 4 years ago by Ryan J Ollos

Replying to jaredbownds:

Where does one apply this patch?

You'll need to checkout the source code from SVN svn co http://trac-hacks.org/svn/childticketsplugin/0.12 childticket-0.12, cd childticket-0.12, apply the patch using patch -p1 < childticketsplugin-ticket_admin_perm.patch and then re-install the plugin: python setup.py install.

comment:7 Changed 10 months ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

In 16096:

2.5.5dev: Require TICKET_ADMIN to access admin pages

Provide support for TracFineGrainedPermissions.

Fixes #10531.

comment:8 Changed 10 months ago by Ryan J Ollos

Owner: changed from Mark Ryan to Sergio Talens-Oliag

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Sergio Talens-Oliag.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.