Opened 5 years ago

Closed 5 years ago

Source has tabs and improper indentation

Reported by: Owned by: Ryan J Ollos Nathan Lewis normal PrivateWikiPlugin normal

Description

The source contains tabs and some improper indentation. I hope you don't mind if I push a fix for this now.

comment:1 follow-up:  6 Changed 5 years ago by Ryan J Ollos

This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?

comment:2 Changed 5 years ago by Nathan Lewis

It seems to working for me. I have been using it for quite some time.

comment:3 Changed 5 years ago by Ryan J Ollos

I just can't get it to work at all without making pretty major changes. I'll push the tab-space fix, and then make a fork on github, setup some tests and stack up some patches.

comment:4 Changed 5 years ago by Ryan J Ollos

Resolution: → fixed new → closed

(In [12369]) Fixes #10634: Converted tabs to spaces and fixed indentation.

comment:5 Changed 5 years ago by Ryan J Ollos

(In [12370]) Refs #10634: Applied misc formatting changes (applied via PyDev autoformatting) to conform to PEP8.

comment:6 in reply to:  1 ; follow-up:  7 Changed 5 years ago by Peter Suter

This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?

I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?

comment:7 in reply to:  6 Changed 5 years ago by Ryan J Ollos

I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?

I made a few comments over in #10635. The first issue I had was due to not reading the documentation well enough, but there is also a more subtle problem having to do with not performing fine-grained checks for WIKI_CREATE. I plan to fix that issue and clean up some of the code in #10635.

Modify Ticket

Change Properties