#10634 closed defect (fixed)
Source has tabs and improper indentation
Reported by: | Ryan J Ollos | Owned by: | Nathan Lewis |
---|---|---|---|
Priority: | normal | Component: | PrivateWikiPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: |
Description
The source contains tabs and some improper indentation. I hope you don't mind if I push a fix for this now.
Attachments (0)
Change History (7)
comment:1 follow-up: 6 Changed 12 years ago by
comment:2 Changed 12 years ago by
It seems to working for me. I have been using it for quite some time.
comment:3 Changed 12 years ago by
I just can't get it to work at all without making pretty major changes. I'll push the tab-space fix, and then make a fork on github, setup some tests and stack up some patches.
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:5 Changed 12 years ago by
comment:6 follow-up: 7 Changed 12 years ago by
Replying to rjollos:
This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?
I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?
comment:7 Changed 12 years ago by
Replying to psuter:
I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?
I made a few comments over in #10635. The first issue I had was due to not reading the documentation well enough, but there is also a more subtle problem having to do with not performing fine-grained checks for WIKI_CREATE
. I plan to fix that issue and clean up some of the code in #10635.
This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?