Modify

Opened 5 years ago

Closed 5 years ago

#10664 closed defect (fixed)

[PATCH] AdminEnumListPlugin does not work on Firefox 17 with Trac 0.12.4

Reported by: Jun Omae Owned by: Ryan J Ollos
Priority: normal Component: AdminEnumListPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

When visiting admin panel, I got the following error.

Timestamp: 2012-11-30 12:52:36
Error: TypeError: a.attributes is null
Source File: http://example.org:3000/chrome/common/js/jquery.js
Line: 55

After applying the following patch, it works well on Firefox 17. Also, I confirmed with Chrome 24 beta, IE 8.

  • adminenumlistplugin/htdocs/adminenumlist.js

     
    1414
    1515       //IE Doesn't stop selecting text when mousedown returns false we need to check
    1616       // That onselectstart exists and return false if it does
    17        var hasOnSelectStart = typeof $(document).attr('onselectstart') != 'undefined';
     17       var hasOnSelectStart = document.onselectstart !== undefined;
    1818
    1919       // Indicates whether we're dragging a row
    2020       var dragging = false;

Attachments (0)

Change History (3)

comment:1 Changed 5 years ago by Ryan J Ollos

Owner: changed from Stepan Riha to Ryan J Ollos
Status: newassigned

comment:2 Changed 5 years ago by Ryan J Ollos

(In [12420]) Refs #10664: Check for existence of onselectstart function was not compatible with all browsers. Patch by Jun Omae (jun66j5).

comment:3 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.