Modify

Opened 5 years ago

Closed 4 months ago

#10675 closed defect (wontfix)

General Wiki Announcements box should not be shown when user has not set their email

Reported by: Ryan J Ollos Owned by:
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: Steffen Hoffmann Trac Release:

Description

The General Wiki Announcements box should not be shown when the user has not set their email.

Screen capture of Announcer panel when email has not been set:

Screen capture of Announcer panel after email has been set:

Attachments (8)

EmailNotSet.png (22.4 KB) - added by Ryan J Ollos 5 years ago.
EmailSet.png (36.1 KB) - added by Ryan J Ollos 5 years ago.
t10675-r12359-1.patch (548 bytes) - added by Ryan J Ollos 5 years ago.
EmailNotSet-AfterPatch.png (19.6 KB) - added by Ryan J Ollos 5 years ago.
EmailNotSet-AfterPatch-2.png (23.2 KB) - added by Ryan J Ollos 5 years ago.
t10675-r12359-2.patch (695 bytes) - added by Ryan J Ollos 5 years ago.
EmailNotSet-AfterPatch-3.png (23.8 KB) - added by Ryan J Ollos 5 years ago.
t10675-r12359-3.patch (4.9 KB) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (15)

Changed 5 years ago by Ryan J Ollos

Attachment: EmailNotSet.png added

Changed 5 years ago by Ryan J Ollos

Attachment: EmailSet.png added

Changed 5 years ago by Ryan J Ollos

Attachment: t10675-r12359-1.patch added

Changed 5 years ago by Ryan J Ollos

Attachment: EmailNotSet-AfterPatch.png added

comment:1 Changed 5 years ago by Ryan J Ollos

Status: newassigned

The patch is simple. After the patch we see:

I can think of two options to improve on the behavior following the patch:

  • Hide the Announcer panel when there are no boxes present.
  • Show a message to indicate that the user needs to set an email to reveal preference boxes.

Changed 5 years ago by Ryan J Ollos

Changed 5 years ago by Ryan J Ollos

Attachment: t10675-r12359-2.patch added

Changed 5 years ago by Ryan J Ollos

comment:2 Changed 5 years ago by Ryan J Ollos

t10675-r12359-2.patch causes the following message to be displayed when there are no preference boxes to display (e.g. when the email address has not been set):

I prefer the way the patch is currently implemented, but a variation of the patch would show the following:

Some considerations:

  • Later on, when distributors other than email exist, we'll have to change the 'email' not in req.session logic to extend to other distributors. Since that will require major changes to the codebase, it doesn't seem like we need to address that at the moment.
  • It appears that it would make sense to also show a similar message when there are no subscribers listed under the Subscription panel, and that some of the existing notify rules should first be checking that the email has been set for user anonymous. That could also be addressed in a follow-on ticket.

Changed 5 years ago by Ryan J Ollos

Attachment: t10675-r12359-3.patch added

comment:3 Changed 5 years ago by Ryan J Ollos

t10675-r12359-3.patch implements a functional test harness, and adds functional tests for the two issues addressed in this ticket. I attempted to use as much of Trac's existing functional test infrastructure as possible, which leaves a TODO since I'm not sure yet how inject a derived instance of FunctionalTester into the FunctionalTestSuite class. I suspect we will need to move towards overriding the setUp and tearDown methods of FunctionalTestSuite (which is what the XmlRpcPlugin and AccountManagerPlugin have done - those are the only two plugins on trac-hacks that I can find which have implemented functional tests).

Since the implementation makes use of FunctionalTestEnvironment.post_create, the tests can only be run under Trac 0.11.5dev or later. There is a check in the code to disable the functional tests when the minimum version of Trac is not met. I don't think the version restriction will significantly hinder development, but let's discuss if you think this will be an issue.

comment:4 Changed 5 years ago by Ryan J Ollos

All the work that I have planned for this ticket has been posted, so this ticket just needs review of the 3 patches.

comment:5 Changed 4 years ago by Ryan J Ollos

Status: assignednew

comment:6 Changed 8 months ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

comment:7 Changed 4 months ago by Ryan J Ollos

Resolution: wontfix
Status: newclosed

Please upgrade to Trac 1.2, which has integrated the core of AnnouncerPlugin. Please raise the issue on the trac:MailingList if you encounter the issue with Trac 1.2.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.