Modify

Opened 11 years ago

Closed 11 years ago

#1069 closed enhancement (fixed)

Modifications via Trac connector in MyLar does not trigger email sending.

Reported by: anonymous Owned by: Alec Thomas
Priority: normal Component: XmlRpcPlugin
Severity: normal Keywords:
Cc: Steffen Pingel, key@…, hwinkel@… Trac Release: 0.10

Description

Steps To Reproduce:

  1. Create task via browser
  2. Modify this task via browser, add a user in the CC field. The user receives

an email abou the task.

  1. Do the same using trac connector, no email is sent when modifications are

done on the tasks.

See mylar bug report: #169574

Attachments (1)

trac-xmlrpc-ticketnitify.patch (3.3 KB) - added by Steffen Pingel 11 years ago.
Patch for email notification

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by anonymous

Cc: Steffen Pingel added; anonymous removed

Changed 11 years ago by Steffen Pingel

Patch for email notification

comment:2 Changed 11 years ago by key@…

Cc: key@… added

I have applied the patch, rebuild egg and put it in the plugins directory. But it still doesn't work. I have also double-checked the contents of the egg to see whether the changes have been applied or not.

trac.conf has the following settings for notifications:

[notification]
always_notify_owner = true
always_notify_updater = true

Did I miss out another setting? Email notification works flawlessy using the browser, though.

comment:3 Changed 11 years ago by Steffen Pingel

Mylar currently does not set notify to true, so emails are not sent. Changing the default to true in the patch (notify=True) should do the trick.

comment:4 Changed 11 years ago by Alec Thomas

Has somebody tested this patch? Does it work okay? If you're happy with it, I'll commit .

comment:5 Changed 11 years ago by Steffen Pingel

I did some testing and it worked for me. I'll update Mylar once this patch is integrated into the XmlRpcPlugin.

comment:6 Changed 11 years ago by key@…

yes thank you! setting notify=True as default notification did work without problems.

comment:7 Changed 11 years ago by anonymous

Cc: hwinkel@… added

comment:8 Changed 11 years ago by Steffen Pingel

Type: defectenhancement

That's two reports of successful usage :).

+1 for merging

comment:9 Changed 11 years ago by Alec Thomas

Resolution: fixed
Status: newclosed

(In [1950]) Send ticket notifications when. Thanks to stp for the patch. Closes #1069.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.