Opened 18 years ago
Closed 15 years ago
#1079 closed enhancement (wontfix)
Use link under the View Tickets tab instead of Custom Query tab
Reported by: | anonymous | Owned by: | Tonin |
---|---|---|---|
Priority: | normal | Component: | BatchModifyPlugin |
Severity: | normal | Keywords: | navigation tab |
Cc: | jujuj | Trac Release: | 0.11 |
Description
Adding yet another tab in the navigation bar can become problematic for any user having the TRAC_ADMIN permissions: the navigation bar becomes too long.
Wouldn't it be possible to use the same Custom Query link below the View Tickets link as in the default Trac behaviour ?
Attachments (0)
Change History (9)
comment:1 Changed 18 years ago by
Owner: | changed from b to ashwin_phatak |
---|
comment:2 Changed 18 years ago by
comment:3 Changed 18 years ago by
Owner: | changed from ashwin_phatak to Tonin |
---|---|
Status: | new → assigned |
The problem to the proposed behaviour is that the Custom Query link is taken care of inside the process_request method of the Trac ReportModule class (see trac/ticket/report.py code):
# Kludge: only show link to custom query if the query module is actually # enabled from trac.ticket.query import QueryModule if req.perm.has_permission('TICKET_VIEW') and \ self.env.is_component_enabled(QueryModule): req.hdf['report.query_href'] = req.href.query()
We see a direct test to the QueryModule to see if it's enabled.. However, the BatchModifyModule needs the QueryModule to be disabled to work. :(
To solve this problem, one should patch Trac, which is not so recommended, or make the BatchModifyModule behave like if it was the QueryModule which is enabled. Not sure how this last option is feasable. Anyone has a clue?
comment:4 Changed 17 years ago by
Resolution: | → wontfix |
---|---|
Status: | assigned → closed |
This is solved in 0.11 via the use of a filter to adjust the output of the built in query page rather than actually create it's own one.
It would be pretty tricky to fix it properly for 0.10 without some kind of ugly hack or patch to Trac itself. So I think this can be closed...
If someone feels strongly to the contrary, please reopen.
comment:5 Changed 16 years ago by
Cc: | jujuj added; anonymous removed |
---|
comment:6 Changed 15 years ago by
If someone feels strongly to the contrary, please reopen. rosetta stone french
comment:7 Changed 15 years ago by
Trac Release: | 0.10 → 0.11 |
---|
The problem to the proposed behaviour is that the Custom Query link is taken care of inside the process_request method of the Trac ReportModule classrosetta stone french
comment:8 Changed 15 years ago by
Resolution: | wontfix |
---|---|
Status: | closed → reopened |
comment:9 Changed 15 years ago by
Resolution: | → wontfix |
---|---|
Status: | reopened → closed |
This looks like it was reopened by a spam bot.
It would be great if this ticket could be fixed, Im getting a way to long nav menu.