Modify

Opened 10 years ago

Closed 7 years ago

#1079 closed enhancement (wontfix)

Use link under the View Tickets tab instead of Custom Query tab

Reported by: anonymous Owned by: Tonin
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords: navigation tab
Cc: jujuj Trac Release: 0.11

Description

Adding yet another tab in the navigation bar can become problematic for any user having the TRAC_ADMIN permissions: the navigation bar becomes too long.

Wouldn't it be possible to use the same Custom Query link below the View Tickets link as in the default Trac behaviour ?

Attachments (0)

Change History (9)

comment:1 Changed 10 years ago by Tonin

Owner: changed from b to ashwin_phatak

comment:2 Changed 10 years ago by anonymous

It would be great if this ticket could be fixed, Im getting a way to long nav menu.

comment:3 Changed 10 years ago by Tonin

Owner: changed from ashwin_phatak to Tonin
Status: newassigned

The problem to the proposed behaviour is that the Custom Query link is taken care of inside the process_request method of the Trac ReportModule class (see trac/ticket/report.py code):

# Kludge: only show link to custom query if the query module is actually
# enabled
from trac.ticket.query import QueryModule
if req.perm.has_permission('TICKET_VIEW') and \
   self.env.is_component_enabled(QueryModule):
    req.hdf['report.query_href'] = req.href.query()

We see a direct test to the QueryModule to see if it's enabled.. However, the BatchModifyModule needs the QueryModule to be disabled to work. :(

To solve this problem, one should patch Trac, which is not so recommended, or make the BatchModifyModule behave like if it was the QueryModule which is enabled. Not sure how this last option is feasable. Anyone has a clue?

comment:4 Changed 9 years ago by Colin Guthrie

Resolution: wontfix
Status: assignedclosed

This is solved in 0.11 via the use of a filter to adjust the output of the built in query page rather than actually create it's own one.

It would be pretty tricky to fix it properly for 0.10 without some kind of ugly hack or patch to Trac itself. So I think this can be closed...

If someone feels strongly to the contrary, please reopen.

comment:5 Changed 8 years ago by anonymous

Cc: jujuj added; anonymous removed

comment:6 Changed 7 years ago by anonymous

If someone feels strongly to the contrary, please reopen. rosetta stone french

comment:7 Changed 7 years ago by anonymous

Trac Release: 0.100.11

The problem to the proposed behaviour is that the Custom Query link is taken care of inside the process_request method of the Trac ReportModule classrosetta stone french

comment:8 Changed 7 years ago by anonymous

Resolution: wontfix
Status: closedreopened

comment:9 Changed 7 years ago by CuriousCurmudgeon

Resolution: wontfix
Status: reopenedclosed

This looks like it was reopened by a spam bot.

Modify Ticket

Action
as closed The owner will remain Tonin.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.