Opened 12 years ago
Closed 8 years ago
#10866 closed enhancement (fixed)
Avoiding error if there is no subversion repository
| Reported by: | Owned by: | Emilien Klein | |
|---|---|---|---|
| Priority: | low | Component: | TicketModifiedFilesPlugin |
| Severity: | minor | Keywords: | |
| Cc: | Trac Release: |
Description
Hello,
I had a minor issue while setting a new trac server at my job: during tests i had an exception if TicketModifiedFilesPlugin was enabled and there was no Subversion repository linked to the Trac project, so i fixed if by testing if the 'repos' value (@line 116 in ticketmodifiedfiles.py) was equal to None : 116 repos = self.env.get_repository() 117 if repos is not None 118 for rev, time, author, message, in cursor: ... [...] 195 repos.close()
See attached file for more details
Attachments (2)
Change History (6)
Changed 12 years ago by
| Attachment: | ticketmodifiedfiles.py added |
|---|
comment:1 follow-up: 2 Changed 12 years ago by
Would you kindly attach your changes as a patch file? See trac:TracDev/SubmittingPatches if you are not familiar with how to do this. Thanks.
comment:2 follow-up: 3 Changed 12 years ago by
Replying to rjollos:
Would you kindly attach your changes as a patch file? See trac:TracDev/SubmittingPatches if you are not familiar with how to do this. Thanks.
Done, my apologies, I wasn't familiar with the "patch files system", this is the first time i create a ticket. Thank you for the information !
comment:3 Changed 12 years ago by
Replying to j43l1us@gmail.com:
Done, my apologies, I wasn't familiar with the "patch files system", this is the first time i create a ticket. Thank you for the information !
No apology necessary ;) Thanks for the patch! I'll try to get it pushed soon.
comment:4 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Seems to be okay now. Probably fixed in r16489.
the modified ticketmodifiedfiles.py