Modify

Opened 4 years ago

Closed 3 months ago

#10934 closed defect (worksforme)

TracHoursByComment breaks GridModify plugin

Reported by: chris@… Owned by: EmeCas
Priority: high Component: TracHoursPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description (last modified by Ryan J Ollos)

I just installed TracHours on my Trac that already had the GridModify plugin installed and working. After enabling all of the TracHours plugins, the GridModify plugin stopped working, ie: after editing a field in the grid, it would not save.

I turned on logging and found the following error:

Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/GridModify-0.1.6dev_r12235-py2.6.egg/gridmod/web_ui.py", line 105, in process_request
    ticket.save_changes(req.authname, None, now)
  File "/usr/lib/python2.6/dist-packages/trac/ticket/model.py", line 360, in save_changes
    listener.ticket_changed(self, comment, author, old_values)
  File "/usr/local/lib/python2.6/dist-packages/TracHoursPlugin-0.6.0dev_r12205-py2.6.egg/trachours/ticket.py", line 111, in ticket_changed
    self.add_hours_by_comment(comment, ticket.id, author)
  File "/usr/local/lib/python2.6/dist-packages/TracHoursPlugin-0.6.0dev_r12205-py2.6.egg/trachours/ticket.py", line 129, in add_hours_by_comment
    for match in re.finditer(self.hours_regex, comment):
  File "/usr/lib/python2.6/re.py", line 186, in finditer
    return _compile(pattern, flags).finditer(string)
TypeError: expected string or buffer

So I turned off the TracHoursByComment plugin, as that looked like it was expecting a comment or at least as empty string, and GridModify works OK now.

I won't be using TracHoursByComment anyway, but thought you might like to know.

Attachments (0)

Change History (7)

comment:1 Changed 4 years ago by Ryan J Ollos

Your report is appreciated! I haven't worked on maintaining the plugin much lately, but I will take a look soon.

comment:2 Changed 4 years ago by Ryan J Ollos

Priority: normalhigh

comment:3 Changed 4 years ago by Ryan J Ollos

Description: modified (diff)

comment:4 Changed 12 months ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

comment:5 Changed 3 months ago by EmeCas

Owner: set to EmeCas
Status: newassigned

Tested using the following versions and everything is working correctly

Trac 1.2

GridModify 1.0.0.dev0

TracHoursPlugin 0.6.0.dev0
    trachours.ticket.* 
        TracHoursByComment  Enabled
Last edited 3 months ago by EmeCas (previous) (diff)

comment:6 Changed 3 months ago by EmeCas

Tested with

Trac 1.0.13

GridModify 1.0.0.dev0

TracHours 0.6.0.dev0

everything is working correctly

comment:7 Changed 3 months ago by EmeCas

Resolution: worksforme
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain EmeCas.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.