Modify

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#10943 closed enhancement (fixed)

[PATCH] Add i18n support and some translations

Reported by: Steffen Hoffmann Owned by: Steffen Hoffmann
Priority: normal Component: VotePlugin
Severity: normal Keywords: i18n l10n
Cc: Dirk Stöcker Trac Release: 0.12

Description

I've noticed, that this plugin is even used at t.e.o, so localized messages would definitely suite much better for a consistent look-and-feel.

I know this is a rather intrusive series of changes, but if you allow, I could even lead that development. Should be rather easy for the few messages we have in here. How do you feel about it?

Attachments (1)

i18n.diff (14.3 KB) - added by Dirk Stöcker 2 years ago.
I18N support for Voteplugin and german translation

Download all attachments as: .zip

Change History (20)

comment:1 Changed 4 years ago by Ryan J Ollos

I'm more than happy to have you push ahead on the work. Please move ahead as your time permits!

comment:2 Changed 4 years ago by Steffen Hoffmann

Keywords: needinfo removed
Owner: changed from Ryan J Ollos to Steffen Hoffmann

Thanks for the heads-up on this one. Will do.

Changed 2 years ago by Dirk Stöcker

Attachment: i18n.diff added

I18N support for Voteplugin and german translation

comment:3 Changed 2 years ago by Dirk Stöcker

Summary: Add i18n support and some translations[PATCH] Add i18n support and some translations

See attached patch.

comment:4 Changed 2 years ago by Ryan J Ollos

In 14264:

0.2dev: Added i18n support. Patch by stoecker. Refs #10943.

comment:5 Changed 2 years ago by Ryan J Ollos

The ListOption doc was not being extracted correctly. I made a few other minor changes, but overall the patch looked good. stoecker, would you mind checking the translation and providing updates that are needed?

Last edited 2 years ago by Ryan J Ollos (previous) (diff)

comment:6 Changed 2 years ago by Ryan J Ollos

In 14265:

0.2dev/l10n: New extraction. Refs #10943.

comment:7 Changed 2 years ago by Ryan J Ollos

Cc: Dirk Stöcker added; anonymous removed

comment:8 Changed 2 years ago by Dirk Stöcker

Added to translation project and updated German texts there: https://www.transifex.com/projects/p/Trac_Plugin-L10N/resource/voteplugin/

Please download file and update SVN.

comment:9 Changed 2 years ago by Ryan J Ollos

Thanks, I'll update the SVN.

I see email notifications from the Trac Plugin L10N project when files are added or updated. However, no notifications from the Trac project. I am watching both projects. Do you have the same behavior?

comment:10 Changed 2 years ago by Ryan J Ollos

In 14266:

0.2dev/l10n: Updated German translation from transifex by Dirk Stöcker . Refs #10943.

comment:11 Changed 2 years ago by Dirk Stöcker

Don't know. Don't watch Trac and also disabled notifications :-)

Please do following property changes as well:

Index: trunk/tracvote/locale/de/LC_MESSAGES
===================================================================
--- trunk/tracvote/locale/de/LC_MESSAGES        (revision 14265)
+++ trunk/tracvote/locale/de/LC_MESSAGES        (working copy)

Property changes on: trunk/tracvote/locale/de/LC_MESSAGES
___________________________________________________________________
Added: svn:ignore
## -0,0 +1 ##
+*.mo
Index: trunk
===================================================================
--- trunk       (revision 14265)
+++ trunk       (working copy)

Property changes on: trunk
___________________________________________________________________
Modified: svn:ignore
## -1,3 +1,5 ##
 .project
 .pydevproject
 *.egg-info
+dist
+build

comment:12 Changed 2 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

Files ignored in [14267].

comment:13 Changed 2 years ago by Dirk Stöcker

*.mo must be ignored in trunk/tracvote/locale/de/LC_MESSAGES . Does not help to do it in main directory. :-)

comment:14 Changed 2 years ago by Ryan J Ollos

In 14268:

Ignore *.mo files on LC_MESSAGES directory and set svn:global-ignores on trunk for SVN 1.8 users. Refs #10943.

comment:15 Changed 2 years ago by Ryan J Ollos

In 14269:

Part of [14268]. Refs #10943.

comment:16 Changed 2 years ago by Steffen Hoffmann

I've just commited updated catalogs in [14326], adding Korean and Spanish translations as well.

comment:17 Changed 2 years ago by Ryan J Ollos

The issue seen in [14326#file0] was recently fixed in Trac: trac:comment:4:ticket:11824. To avoid the issue though message extraction needs to be done with Trac >= trac:r13311.

Last edited 2 years ago by Ryan J Ollos (previous) (diff)

comment:18 in reply to:  17 Changed 2 years ago by Jun Omae

Replying to rjollos:

The issue seen in [14326#file0] was recently fixed in Trac: trac:comment:4:ticket:11824. To avoid the issue though message extraction needs to be done with Trac >= trac:r13311.

I don't think that is a workaround. If Trac 1.0.3dev r13311 and later is used, extracted messages certainly don't have trailing spaces. However, if 1.0.2 and early is used, extract messages have trailing spaces and the messages wouldn't be translated.

comment:19 Changed 2 years ago by Ryan J Ollos

I hadn't really considered it a workaround, it was just a comment about how Trac will behave in the future. Anyway, the changes in trac:r13311 were applied to the trunk and will be included in 1.1.3dev, so they aren't applicable to 1.0.3 as suggested in comment:18.

Modify Ticket

Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.