Modify

Opened 10 years ago

Closed 9 years ago

#1096 closed defect (worksforme)

Traceback on !HttpAuthStore when password is wrong

Reported by: Eli Carter Owned by: Matt Good
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.10

Description

Using HttpAuthStore, logging in with a correct username/password works, but an incorrect username/password gives a traceback instead of a "login failed" message.

This is with 0.10.

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 356, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 189, in dispatch
    req.authname = self.authenticate(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 145, in authenticate
    authname = authenticator.authenticate(req)
  File "/usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r1549-py2.4.egg/acct_mgr/web_ui.py", line 316, in wrap
    return func(self, *args, **kwds)
  File "/usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r1549-py2.4.egg/acct_mgr/web_ui.py", line 326, in authenticate
    req.environ['REMOTE_USER'] = self._remote_user(req)
  File "/usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r1549-py2.4.egg/acct_mgr/web_ui.py", line 353, in _remote_user
    if AccountManager(self.env).check_password(user, password):
  File "/usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r1549-py2.4.egg/acct_mgr/api.py", line 104, in check_password
    return self.password_store.check_password(user, password)
  File "/usr/lib/python2.4/site-packages/TracAccountManager-0.1.3dev_r1549-py2.4.egg/acct_mgr/http.py", line 30, in check_password
    HTTPDigestAuthHandler(mgr)).open(self.auth_url)
  File "/usr/lib/python2.4/urllib2.py", line 364, in open
    response = meth(req, response)
  File "/usr/lib/python2.4/urllib2.py", line 471, in http_response
    response = self.parent.error(
  File "/usr/lib/python2.4/urllib2.py", line 396, in error
    result = self._call_chain(*args)
  File "/usr/lib/python2.4/urllib2.py", line 337, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.4/urllib2.py", line 741, in http_error_401
    host, req, headers)
  File "/usr/lib/python2.4/urllib2.py", line 720, in http_error_auth_reqed
    return self.retry_http_basic_auth(host, req, realm)
  File "/usr/lib/python2.4/urllib2.py", line 730, in retry_http_basic_auth
    return self.parent.open(req)
  File "/usr/lib/python2.4/urllib2.py", line 364, in open
    response = meth(req, response)
  File "/usr/lib/python2.4/urllib2.py", line 471, in http_response
    response = self.parent.error(
  File "/usr/lib/python2.4/urllib2.py", line 396, in error
    result = self._call_chain(*args)
  File "/usr/lib/python2.4/urllib2.py", line 337, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.4/urllib2.py", line 916, in http_error_401
    host, req, headers)
  File "/usr/lib/python2.4/urllib2.py", line 807, in http_error_auth_reqed
    raise ValueError("AbstractDigestAuthHandler doesn't know "
ValueError: AbstractDigestAuthHandler doesn't know about Basic

Attachments (1)

accountmanagerplugin-quick-hack-for-1096.patch (779 bytes) - added by Eli Carter 10 years ago.
Brute force "solution"

Download all attachments as: .zip

Change History (2)

Changed 10 years ago by Eli Carter

Brute force "solution"

comment:1 Changed 9 years ago by John Hampton

Resolution: worksforme
Status: newclosed

can't duplicate this. I'm guessing that since this ticket is so old, it's been fixed in the current 0.10 and trunk versions. However, I don't really want to go looking for the changeset where this was fixed.

Modify Ticket

Action
as closed The owner will remain Matt Good.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.