Modify ↓

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#10984 closed defect (fixed)

Redefined labels show without colons when submitting a ticket

Reported by: ngpitt@… Owned by: Ryan J Ollos
Priority: normal Component: BlackMagicTicketTweaksPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

When submitting a ticket with custom labels configured, the label does not show with colons.

I haven't tried fixing this, but I have a feeling that it's as simple as appending a colon to the field label under #ticket page in blackmagic.py.

Attachments (0)

Change History (6)

comment:1 Changed 12 years ago by Ryan J Ollos

Owner: changed from obs to Ryan J Ollos
Status: new → assigned

Thanks for the report, I will take a look.

comment:2 in reply to:  description Changed 12 years ago by Ryan J Ollos

Replying to ngpitt@xphysics.net:

I haven't tried fixing this, but I have a feeling that it's as simple as appending a colon to the field label under #ticket page in blackmagic.py.

You are right. We are replacing the text content of the label, but failing to append a colon again, ​as was done when the text was initially rendered.

comment:3 Changed 12 years ago by Ryan J Ollos

Resolution: → fixed
Status: assigned → closed

(In [12864]) Fixes #10984: Append a colon to the new label text when replacing the label text. Thanks to ngpitt@… for the report.

comment:4 Changed 12 years ago by Ryan J Ollos

Here is the configuration that I used for testing: 

[blackmagic]
priority.label = Importance
tweaks = priority

comment:5 Changed 12 years ago by Ryan J Ollos

... and keep those bug reports coming ;)

comment:6 Changed 12 years ago by Ryan J Ollos

(In [12948]) Fixes #11004, Refs #10984: Append a colon to the label in the property box too. This change should have been part of [12864].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.