#11118 closed defect (fixed)
Update button on the Query page can be hidden by hide rules
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Component: | DynamicFieldsPlugin |
Severity: | normal | Keywords: | pull-request |
Cc: | Trac Release: |
Description
As discussed on the mailing list, the hide rule that is applied to Priority will also hide the div enclosing the Update button on the Query page.
This is because the selector input[value="priority"]
will also capture the hidden input
element,
<div class="buttons"> <input type="hidden" name="order" value="priority"> <input type="submit" name="update" value="Update"> </div>
and its parent that also encloses the Update button will be hidden.
Attachments (0)
Change History (8)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Keywords: | pull-request added |
---|
comment:3 Changed 11 years ago by
Rob, have you had a chance to look at the changeset, and any thoughts on whether you'd be okay with me publishing these changes to the trac-hacks repository?
comment:5 Changed 11 years ago by
Owner: | changed from Rob Guttman to Ryan J Ollos |
---|
comment:6 Changed 11 years ago by
Ryan, thanks so much for your help! Feel free to help maintain any of my plugins at anytime.
comment:7 Changed 11 years ago by
Thanks Rob! I look forward to contributing more.
If you find a moment, would you mind taking a look at #10476 and let me know what you think? I'm mainly trying to understand the motivation for the initial change to case-sensitive options (comment:4:ticket:10476).
Patch in 3e2f3e11. I tested with Trac
0.11.0
and Trac1.0.2dev
. As far as pushing the change goes, same request as in comment:3:ticket:10476. Thank you for your time and review of the changes.