Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#11118 closed defect (fixed)

Update button on the Query page can be hidden by hide rules

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: DynamicFieldsPlugin
Severity: normal Keywords: pull-request
Cc: Trac Release:


As discussed on the mailing list, the hide rule that is applied to Priority will also hide the div enclosing the Update button on the Query page.

This is because the selector input[value="priority"] will also capture the hidden input element,

<div class="buttons">
          <input type="hidden" name="order" value="priority">
          <input type="submit" name="update" value="Update">

and its parent that also encloses the Update button will be hidden.

Attachments (0)

Change History (8)

comment:1 Changed 4 years ago by Ryan J Ollos

Patch in 3e2f3e11. I tested with Trac 0.11.0 and Trac 1.0.2dev. As far as pushing the change goes, same request as in comment:3:ticket:10476. Thank you for your time and review of the changes.

comment:2 Changed 4 years ago by Ryan J Ollos

Keywords: pull-request added

comment:3 Changed 4 years ago by Ryan J Ollos

Rob, have you had a chance to look at the changeset, and any thoughts on whether you'd be okay with me publishing these changes to the trac-hacks repository?

comment:4 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

In 13536:

Fixes #11118: Use a more precise selector for hiding the select and option elements on the Query page to avoid also applying the hide method to the parent of the hidden input element with value = priority when a hide rule applies to the ticket's Priority.

comment:5 Changed 4 years ago by Ryan J Ollos

Owner: changed from Rob Guttman to Ryan J Ollos

comment:6 Changed 4 years ago by Rob Guttman

Ryan, thanks so much for your help! Feel free to help maintain any of my plugins at anytime.

comment:7 Changed 4 years ago by Ryan J Ollos

Thanks Rob! I look forward to contributing more.

If you find a moment, would you mind taking a look at #10476 and let me know what you think? I'm mainly trying to understand the motivation for the initial change to case-sensitive options (comment:4:ticket:10476).

comment:8 Changed 3 years ago by Ryan J Ollos

In 13650:

Bump version to 1.2.4. Refs #11378, #11118, #11523, #10126, #9605, #9986, #9996, #8971.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.