AttributeError: 'TracHacksHtPasswdStore' object has no attribute 'user_email_verification_requested'

[Ryan J Ollos]

Two users have reported this issue. It appears to be due to the HtPasswdStore implementation in TracHacksPlugin not having been adapted to the AccountManagerPlugin 0.4 API (IAccountChangeListener).

[Ryan J Ollos]

In 13272:

Refs #11154: Added pass-through implementations of two missing IAccountChangeListener methods (for AccountManagerPlugin 0.4.3).

[Ryan J Ollos]

[13271] was just a quick workaround until we get some real expertise (hasienda) on the problem.

[Steffen Hoffmann]

Replying to rjollos:

[13271] was just a quick workaround until we get some real expertise (hasienda) on the problem.

Approved. Accidentally I've been planning a major rework of the change listener interface in question. But didn't search for existing implementations yet. Once finished, it will no longer blew-up when calling older listeners that naturally will miss methods or have incompatible method signatures.

[Chris Nelson]

When logging in I see:

An email has been sent to with a token to verify your new email address.

but the e-mail never showed up. Still, I seem to be able to use the system.

[Steffen Hoffmann]

Replying to ChrisNelson:

When logging in I see:

An email has been sent to with a token to verify your new email address.

but the e-mail never showed up. Still, I seem to be able to use the system.

A bit strange indeed. First, there is no email. It should be mentioned in the text between "has been sent to" and "with a token", but it is not. Second, until providing the valid verification token you should all elevated permissions should be stripped from the authenticated session, with an exception for admin users, but that group should not be challenged in the first place. Btw, any regular user will get challenged again after changing a verified address.

[Ryan J Ollos]

Replying to hasienda:

Approved. ...

I'll go ahead and close then, but please reopen if you think there should be additional work done related to this ticket.