Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11166 closed enhancement (fixed)

About timeline filter behavior

Reported by: anonymous Owned by: falkb
Priority: normal Component: SimpleMultiProjectPlugin
Severity: minor Keywords:
Cc: ykrocku@… Trac Release: 1.0

Description (last modified by Ryan J Ollos)

In timeline page, there is a "Filter projects" option added by simple multiproject plugin. It only display the selected project's events when a project selected. I got a little confused about the 'ALL' option.I assume the 'ALL' option shouldn't filter out any events, but indeed it filter out changes made to those tickets without its custom field 'project' set.

Here is the way I think 'ALL' option should work

if template == 'timeline.html':
    filter_projects = self._filtered_projects(req)
    if not filter_projects: #no filter means likely more than 1 project, so we insert the project name
-        filter_projects = [project[1] for project in self.__SmpModel.get_all_projects()]
+        return template, data, content_type

Attachments (0)

Change History (8)

comment:1 Changed 11 years ago by ykrocku@…

Cc: ykrocku@… added; anonymous removed

Forget to add my email address

comment:2 Changed 11 years ago by anonymous

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

comment:3 in reply to:  2 Changed 11 years ago by ykrocku@…

Replying to anonymous:

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

Yeah, but I think it is better than the way it works now.

comment:4 Changed 11 years ago by falkb

Status: newassigned

comment:5 Changed 11 years ago by falkb

In 13291:

bugfix: if "All" is set as timeline filter, display also tickets without a set project (refs #11166)

comment:6 Changed 11 years ago by falkb

ykrocku, please test and close this ticket if it's OK now. Thanks a lot for reporting.

comment:7 Changed 11 years ago by ykrocku@…

Resolution: fixed
Status: assignedclosed

Test ok

comment:8 Changed 11 years ago by Ryan J Ollos

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain falkb.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.