Opened 5 years ago

Closed 5 years ago

#11166 closed enhancement (fixed)

Reported by: Owned by: anonymous falkb normal SimpleMultiProjectPlugin minor ykrocku@… 1.0

In timeline page, there is a "Filter projects" option added by simple multiproject plugin. It only display the selected project's events when a project selected. I got a little confused about the 'ALL' option.I assume the 'ALL' option shouldn't filter out any events, but indeed it filter out changes made to those tickets without its custom field 'project' set.

Here is the way I think 'ALL' option should work

if template == 'timeline.html':
filter_projects = self._filtered_projects(req)
if not filter_projects: #no filter means likely more than 1 project, so we insert the project name
-        filter_projects = [project[1] for project in self.__SmpModel.get_all_projects()]
+        return template, data, content_type


comment:2 follow-up:  3 Changed 5 years ago by anonymous

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

comment:3 in reply to:  2 Changed 5 years ago by ykrocku@…

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

Yeah, but I think it is better than the way it works now.

comment:4 Changed 5 years ago by falkb

Status: new → assigned

comment:5 Changed 5 years ago by falkb

In 13291:

bugfix: if "All" is set as timeline filter, display also tickets without a set project (refs #11166)

comment:6 Changed 5 years ago by falkb

ykrocku, please test and close this ticket if it's OK now. Thanks a lot for reporting.

comment:7 Changed 5 years ago by ykrocku@…

Resolution: → fixed assigned → closed

Test ok

comment:8 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

Modify Ticket

Change Properties
Action
as closed The owner will remain falkb.
The resolution will be deleted.