Modify ↓

Opened 11 years ago

Closed 11 years ago

#11170 closed defect (fixed)

Reset width and height of textarea after changing orders of custom fields

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Component: CustomFieldAdminPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

How to reproduce

  1. Add custom field as textarea with 42 for width and 3 for height
  2. Visit "Manage Custom Fields" panel and click "Apply changes" button
  3. Reset cols and rows of the field to default

TicketSystem.get_custom_fields() returns width and height property in a ditionary for textarea type. However, the properties are field-name.cols and field-name.rows in trac.ini. Therefore, the plugin doesn't keep the values.

customfieldadminplugin-r13282.diff​, unit tests pass on Trac 0.11.3 - 1.0.1.

Attachments (1)

customfieldadminplugin-r13282.diff​ (4.0 KB) - added by Jun Omae 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Jun Omae

Attachment: customfieldadminplugin-r13282.diff​ added

comment:1 Changed 11 years ago by Jun Omae

Another thing is that the cols field gets focus after clicking the rows field on Firefox. The patch includes the fix for it.

comment:2 Changed 11 years ago by anonymous

Owner: changed from osimons to Jun Omae

Thanks - looks good to me. Jun, feel free to commit this yourself.

Last edited 11 years ago by osimons (previous) (diff)

comment:3 Changed 11 years ago by Jun Omae

Resolution: → fixed
Status: new → closed

In 13289:

CustomFieldAdminPlugin: Keep width and height of textarea type when custom fields are ordered and fixed the label element for rows field. Closes #11170.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.