Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11191 closed defect (duplicate)

Use plugin's own permissions instead of WIKI_* for TagsPlugin integration

Reported by: Steffen Hoffmann Owned by: Radek Bartoň
Priority: normal Component: ScreenshotsPlugin
Severity: normal Keywords: tagging
Cc: Steffen Hoffmann, Ryan J Ollos Trac Release:

Description

While the plugin defines a lot of permission action in tracscreenshots.core, it doesn't consequently use them, especially not in the optional ScreenshotsTagProvider component in 'tracscreenshots.tags'.

Attachments (1)

20130623_fx-tagperms.patch (1.6 KB) - added by Steffen Hoffmann 4 years ago.
proposed patch to actually check for 'SCREENSHOTS_*' permissions

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by Steffen Hoffmann

Attachment: 20130623_fx-tagperms.patch added

proposed patch to actually check for 'SCREENSHOTS_*' permissions

comment:1 Changed 4 years ago by Steffen Hoffmann

Ryan, IIRC you've been given plugin maintenance privileges by the author himself. Would you take care for this and future tickets, or may I accompany you in caring for this nice hack?

comment:2 Changed 4 years ago by Steffen Hoffmann

Resolution: duplicate
Status: newclosed

This has been reported by myself in #10940. But I'll aim at resolving it according to the more elaborated approach in the patch published here.

comment:3 in reply to:  1 Changed 4 years ago by Ryan J Ollos

Replying to hasienda:

Ryan, IIRC you've been given plugin maintenance privileges by the author himself. Would you take care for this and future tickets, or may I accompany you in caring for this nice hack?

Yes, please feel free to proceed however you like. I might have pushed a few patches for the plugin, but I don't have current plans to maintain it long term, and I'm not currently using it.

p.s. Sorry for the delayed reply!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Radek Bartoň.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.