Modify

Opened 3 years ago

Last modified 6 weeks ago

#11197 new defect

[PATCH] AutocompleteUsers plugin conflicts with KeywordSuggest plugin

Reported by: AllenB Owned by:
Priority: normal Component: AutocompleteUsersPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

The KeywordSuggestPlugin uses the autocomplete API from jQuery, and it uses the jQuery version that is bundled with Trac (for Trac release 1.0 and later). The AutocompleteUsersPlugin includes its own jQuery autocomplete library. When both of these plugins are loaded, the AutocompleteUsersPlugin works but the KeywordSuggestPlugin does not. Presumably, this is because the plugin load order is causing the autocomplete library from the AutocompleteUsersPlugin to override functionality from Trac's jQuery library.

The true solution to this problem is for this plugin to use Trac's jQuery library as well. This is most likely not a trivial task. In the meantime, I have developed a workaround that allows both plugins to coexist peacefully.

The attached patch prefixes all "autocomplete" identifiers in the javascript code with "aup_" (for Autocomplete Users Plugin). This prevents name collisions with Trac's jQuery library, but does not appear to impact the functionality of this plugin.

Attachments (2)

playnice.patch (6.6 KB) - added by AllenB 3 years ago.
Workaround
AutocompleteUsersPlugin.diff (4.1 KB) - added by ntmlod 6 weeks ago.
Fix JQuery issue in using AutocompleteUsersPlugin with TagsPlugin

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by AllenB

Workaround

comment:1 Changed 3 years ago by rjollos

  • Status changed from new to accepted

comment:2 Changed 17 months ago by rjollos

  • Owner rjollos deleted
  • Status changed from accepted to new

Refocusing.

comment:3 Changed 6 weeks ago by ntmlod

Hello,

I think I'm facing a similar issue with the TagsPlugin that have the same kind of auto-complete feature for the tag field.

In my case, the auto complete still works for TagsPlugin but not for AutocompleteUsersPlugin. Now when I want to change the 'Cc'ers of a ticket I have no more suggestion contrary to the 'Keywords' field.

I'm gonna look at the fix proposed by AllenB and see if it's still solve this issue.

Changed 6 weeks ago by ntmlod

Fix JQuery issue in using AutocompleteUsersPlugin with TagsPlugin

Add Comment

Modify Ticket

Action
as new The ticket will remain with no owner.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.