Modify

Opened 11 years ago

Last modified 3 years ago

#11303 new defect

[Patch] req.remote_user is not always set

Reported by: Andras Korn Owned by: Carlos López Pérez
Priority: normal Component: AccountLdapPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Hi,

I played around with this plugin a bit because it didn't seem to do anything.

Apparently, req.remote_user isn't (always?) set, so I modified it to use req.authname instead. It now works for me, but I don't know if this is a correct solution.

The attached patch contains this change as well as:

  • messages and HTML template (of 0.12 branch) translated into English (sorry, not proper l10n, I just updated the hardcoded strings);
  • it retrieves displayName instead of cn to get the name (this should really be configurable, I suppose);
  • it now supports non-ascii characters in names;
  • some code typos were fixed;
  • I added some debug logging.

Attachments (1)

accountldap_english_authname.diff (8.2 KB) - added by Andras Korn 11 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 11 years ago by Andras Korn

Summary: req.remote_user is not always set[Patch] req.remote_user is not always set

Changed 11 years ago by Andras Korn

comment:2 Changed 3 years ago by figaro

See also #3171.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Carlos López Pérez.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.