Modify ↓

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11435 closed defect (fixed)

Make tag provider signature conform to interface definition

Reported by: Steffen Hoffmann Owned by: osimons
Priority: normal Component: FullBlogPlugin
Severity: normal Keywords: provider
Cc: Ryan J Ollos Trac Release: 0.11

Description

As reported in #11434 tag providers did not strictly conform to the interface definition (see ITagProvider class definition in tractags/api.py).

While one might argue, that issues could be prevented by defensive programming, I'd prefer to fix it. Here​ is the small change required for this plugin. Thanks for taking care in advance.

Attachments (1)

20131208_fix_tag-provider.patch​ (464 bytes) - added by Steffen Hoffmann 11 years ago.
proposed fix for FullBlogTagSystem.get_tagged_resources

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Steffen Hoffmann

Attachment: 20131208_fix_tag-provider.patch​ added

proposed fix for FullBlogTagSystem.get_tagged_resources

comment:1 Changed 11 years ago by osimons

Resolution: → fixed
Status: new → closed

In 13462:

FullBlogPlugin: Conform to latest version of Tags API. Closes #11435.

comment:2 Changed 11 years ago by Steffen Hoffmann

In 13802:

TagsPlugin: Log ITagProvider issue as warning, refs #11435 and #11658.

Since [13427] TagSystem.get_all_tags() requires stricter API conformance
of ITagProvider implementations regarding its get_tagged_resources method.
Own implementations have been fixed in [13461], but we keep the extra
'try-catch' from [13799-13800] for easier detection of the same issue with
other ITagProviders, namely versions of FullBlogPlugin before r13462.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.