Exceptions in AccountModule._reset_password_enabled are not trapped in Trac 1.0.2dev

[Ryan J Ollos]

While investigating #10980 using Trac 1.0.2dev, with the reporter's configuration I immediately saw a warning:

close Warning: Error with navigation contributor "AccountModule"

It looks like some changes are needed after ​[trac 12068].

accountmanagerplugin/trunk/acct_mgr/web_ui.py

@@ -19 +19 @@
 
 from trac import perm, util
 from trac.core import Component, implements
-from trac.config import Configuration, BoolOption, IntOption, Option
+from trac.config import Configuration, ConfigurationError, BoolOption, \
+                        IntOption, Option
 from trac.env import open_environment
 from trac.prefs import IPreferencePanelProvider
 from trac.util import hex_entropy
@@ -106 +107 @@
     def _reset_password_enabled(self, log=False):
         try:
             self.store.hash_method
-        except AttributeError:
+        except (AttributeError, ConfigurationError):
             return False
         return is_enabled(self.env, self.__class__) and \
                self.reset_password and (self._write_check(log) != []) and \

[Steffen Hoffmann]

In 14274:

AccountManagerPlugin: Define a compatibility class for trapping a new Trac exception, refs #11469.

New error class ConfigurationError has been added during development for
1.0.2, and AccountModule must handle it gracefully for that and all coming
versions of Trac.

[Ryan J Ollos]

Replying to hasienda:

New error class ConfigurationError has been added during development for 1.0.2, and AccountModule must handle it gracefully for that and all coming versions of Trac. }}}

That class was actually available back in Trac 0.11, possibly earlier: ​browser:/tags/trac-0.11/trac/config.py@:29-30#L15. The change on 1.0.2 was just to raise that exception class when ExtensionOption has an Interface that is not registered.

[Steffen Hoffmann]

Ok, clearly I misunderstood ​Trac changeset 12068 then. Thanks for pointing this out.

[Steffen Hoffmann]

In 14277:

AccountManagerPlugin: Remove compatibility class, refs #11469.

Actually ConfigurationError has already been available in Trac 0.10, so
the compatibility code from [14274] is obsolete and removed, effectively
reverting to the originally proposed changes.

Thanks to Ryan J Ollos for initial report as well as for reviewing most of
my changes.