Update DataSaverPlugin to use browser localStorage when possible.

[Tiago Teresa Teodósio]

As there is a 4KB limit on the cookie size, larger form data can't be saved. I propose the usage of browser localStorage when possible.

There is a proposed implementation attached, based on datasaverplugin/trunk/datasaver/htdocs/datasaver.js?rev=8703​

[Steffen Hoffmann]

Tested with nearly 600000 chars, just works.

Even if we did not yet enforce an explicit declaration of consent I do assume, that you're ok with including your code into the GPL'ed source of this plugin, right?

[Tiago Teresa Teodósio]

Yes, my code is given to the public under the same license of the original code.

[Steffen Hoffmann]

In 13550:

DataSaverPlugin: Break the 4 kB storage limit for browser cookies, refs #11474.

Thanks to TiagoTT the JavaScript code uses localStorage now, what is great!

[Tiago Teresa Teodósio]

I am very sorry, but I realized there is an error on the JavaScript code, which however did not prevent it from working as expected.

I attached the patch with the fix.

This is how the patch was produced, on the repository root:

svn diff > js_bug_fix.diff

Again I am sorry for the trouble.

[Steffen Hoffmann]

In 13560:

DataSaverPlugin: Correct new JavaScript function name, refs #11474.

[Steffen Hoffmann]

Replying to TiagoTT:

I am very sorry, but I realized there is an error on the JavaScript code, ...

Hey, thanks for the notice. I've looked through, but not checked the code that thoroughly myself, so this is partially my fault too. Really interesting, that it doesn't bail out, but I bet, that a look at firebug console would have told me about it.

Anyway, I've quickly applied the fix, so not much harm done for now.

Again I am sorry for the trouble.

Na, don't worry. Bugs lure on the way to improvements, but without a change there isn't a chance for improvements at all. I'm still glad you brought the issue up.