Extra character at end of line

[palmerb@…]

An extra character is added after the cr/lf of text. This causes problems when pulling the wiki pages as well in viewing and editing tickets in Mylyn. My ssystem

System Information

Package	Version
Trac	1.0
Genshi	0.6 (without speedups)
GIT	1.7.9
pysqlite	2.6.0
Python	2.7.3 (default, Apr 10 2012, 23:31:26) [MSC v.1500 32 bit (Intel)]
RPC	1.1.2
setuptools	0.6c11
SQLite	3.6.21
jQuery	1.7.2

Installed Plugins

Name	Version	Location
BackLinks	N/A	e:\obss\plugins\BackLinks.py
tracaccountmanager	0.2.1dev	c:\python27\lib\site-packages\tracaccountmanager-0.2.1dev-py2.7.egg
tracgit	0.12.0.2dev	c:\python27\lib\site-packages\tracgit-0.12.0.2dev-py2.7.egg
trachttpauth	1.1	c:\python27\lib\site-packages\trachttpauth-1.1-py2.7.egg
tracxmlrpc	1.1.2	c:\python27\lib\site-packages\tracxmlrpc-1.1.2-py2.7.egg

[osimons]

It causes "problems"? Care to explain the issue in more detail?

Following [6053] all line endings for strings from RPC should be \r\n, and it is not clear to me either what the extra character is or how it appears.

Have you tried to use something like curl to make a request and compare the content you receive (see the API docs for examples)? Does it happen for both JSON and XML? Could it be an issue with your client interface and not the server?

[osimons]

Ah, [6053] fixed input of strings only.

Perhaps you better review #2482, and then follow the actual string output to see where it changes to something unexpected - using raw requests and alternative clients if possible.

[palmerb@…]

At first I thought it was just my code. I updated Trac and then XMLRPCplugin to make it work with Mylyn in Eclipse. Then I updated my documentation which uses Java to get the wiki pages and create a set of HTML pages in documentation. When I ran it there appeared these strange characters that I finally was able to replace using the following code:

char c[] = new char[1];
c[0]='\ufffd';
pageHtml = pageHtml.replaceAll(new String(c), "");

It also appears in Mylyn when viewing any text field with cr/lf.

I agree that this is weird but I am using the org.lustin.trac library and Mylyn is using something else for getting the data. This leads back to the plugin.

[osimons]

Oh, perhaps a regression from [13728:13729]? What if you revert RPC to revisions preceeding these changes?

[palmerb@…]

I traced this through the request and looked at the raw data being returned. For whatever reason the \r is coming back as \ufffd rather than as \u000d.

Doesn't trigger any thoughts at this time. I fixed it for my documentation using the code above but can't do anything about Mylyn. It is not the end of the world as it goes back into the database correctly without any problems.

[osimons]

I've reopened #11050. We'll get this fixed.

[osimons]

In 13776:

XmlRpcPlugin: Tweak [13728] fix again to let carriage return pass through. Closes #11050 again. Also closes #11635.

[osimons]

Please update to latest trunk from repository. The issue should be fixed now. Reopen ticket if not.

[anonymous]

It works. Thanks for making this all work together and for making something that really helps my work. Also the speed with which this was fixed was impressive.