Modify

Opened 3 years ago

Closed 2 years ago

#11655 closed defect (fixed)

Wrong layout caused by ".buttons { clear: both }" in boxes.css

Reported by: Jun Omae Owned by: Mikael Relbe
Priority: normal Component: WikiExtrasPlugin
Severity: normal Keywords:
Cc: Dirk Stöcker Trac Release: 1.0

Description

wikiextras/css/boxes.css has the following style.

#attachments, .buttons {
    clear: both;
}

The style leads wrong layout for <div class="buttons">...</div> area in any pages. I don't think good idea to use such clear: both.

Attachments (1)

20140331T162321.png (31.9 KB) - added by Jun Omae 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by Jun Omae

Attachment: 20140331T162321.png added

comment:1 Changed 2 years ago by Ryan J Ollos

Cc: Dirk Stöcker added

We are having this issue on t-h.o as well. Is it okay if we push Jun's change to the repository?

comment:2 in reply to:  1 Changed 2 years ago by Mikael Relbe

Replying to rjollos:

We are having this issue on t-h.o as well. Is it okay if we push Jun's change to the repository?

Yes, please feel free to do that. I haven't spent much time on Trac dev for a long time now, but plan to take that up soon again. Until then, I am thankful for any help that improves this plugin.

comment:3 Changed 2 years ago by Ryan J Ollos

Thanks. I'll push the change now and redeploy the plugin to t-h.o.

comment:4 Changed 2 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

In 14307:

0.13.2dev: Removed style that caused buttons to be mispositioned. Fixes #11655.

Patch by Jun Omae.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Mikael Relbe.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.