Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#11824 closed enhancement (fixed)

Add dependency to setuptools installation requirements

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: TracJenkinsPlugin
Severity: normal Keywords:
Cc: Wertilq Trac Release:

Description

The following change will result in the jenkinsapi dependency being automatically installed from PyPI.

  • setup.py

     
    4040                        'htdocs/css/images/*.png',
    4141                        'htdocs/js/*.js']
    4242
    43     }
     43    },
     44    install_requires=['jenkinsapi'],
    4445)

I'm going to go ahead and commit this change. I hope that's okay, but if for any reason not, just let me know.

I also fixed up the directory structure in [13969:13971].

Attachments (0)

Change History (3)

comment:1 Changed 3 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

In 13972:

Added dependency to setuptool installation requirements. Fixes #11824.

comment:2 Changed 3 years ago by Ryan J Ollos

Btw, the output when installing is:

Processing dependencies for TracJenkinsPlugin==1.0
Searching for jenkinsapi
Reading http://pypi.python.org/simple/jenkinsapi/
Best match: jenkinsapi 0.2.19
Downloading https://pypi.python.org/packages/source/j/jenkinsapi/jenkinsapi-0.2.19.tar.gz#md5=55bb9d860713147a2d5cfb8ebf410ec9
Processing jenkinsapi-0.2.19.tar.gz
Writing /tmp/easy_install-hgsQI2/jenkinsapi-0.2.19/setup.cfg
Running jenkinsapi-0.2.19/setup.py -q bdist_egg --dist-dir /tmp/easy_install-hgsQI2/jenkinsapi-0.2.19/egg-dist-tmp-DLRvH1
Adding jenkinsapi 0.2.19 to easy-install.pth file
Installing jenkins_invoke script to /home/user/Workspace/th10947/py2.7/bin

Installed /home/user/Workspace/th10947/py2.7/lib/python2.7/site-packages/jenkinsapi-0.2.19-py2.7.egg
Searching for requests>=1.2.3
Reading http://pypi.python.org/simple/requests/
Best match: requests 2.3.0
Downloading https://pypi.python.org/packages/source/r/requests/requests-2.3.0.tar.gz#md5=7449ffdc8ec9ac37bbcd286003c80f00
Processing requests-2.3.0.tar.gz
Writing /tmp/easy_install-gafbgL/requests-2.3.0/setup.cfg
Running requests-2.3.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-gafbgL/requests-2.3.0/egg-dist-tmp-KE6wBM
Adding requests 2.3.0 to easy-install.pth file

Which shows that jenkinsapi is installed from PyPI.

comment:3 Changed 3 years ago by Wertilq

oh right I forgot about jenkinsapi being required, was a month or so since I worked on this.

It's great that you add dependencies and other such things.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.