Opened 10 years ago

Last modified 7 years ago

#11859 new enhancement

[PATCH] Fix plugin for Trac >= v1.0

Reported by: Miguel Ferreira Owned by:
Priority: normal Component: TracWikiToPdfPlugin
Severity: blocker Keywords:
Cc: Trac Release: 1.0


The patch attached addresses the missing images from the generated pdf. In past trac versions, attached file paths were more easily found from the filesystem. Now they are hashed into the filesystem.

Issues solved:

  • Images are now included in generated pdf
  • Book creation bug when getting wiki page names fixed
  • Not using 'utf-8' as codepage since it is not supported by htmldoc 1.8. Instead using ISO-8859-1 fixes output for characters such as 'ä'

This has been tested with Trac v 1.0.1 and the latest development trunk. Don't forget to set base_dir under [wikitopdf] to your trac project environment as a folder path, e.g. /var/lib/trac/test_environment.

Attachments (2)

wikitopdf_trac_v10.diff (6.4 KB) - added by Miguel Ferreira 10 years ago.
patch to fix images in pdf trac v1
fix-pdfplugin.diff (6.5 KB) - added by anonymous 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Miguel Ferreira

Attachment: wikitopdf_trac_v10.diff added

patch to fix images in pdf trac v1

Changed 10 years ago by anonymous

Attachment: fix-pdfplugin.diff added

comment:1 Changed 9 years ago by Ryan J Ollos

#10783 closed as duplicate. TODO confirm fix for #10783 after applying patch.

comment:2 Changed 9 years ago by michela@…

Patched trunk v0.11 with above but couldn't get any images in PDF with Trac 1.1.4. Did the plugin ever work with images that are displayed from a git repo? (e.g. image url starting with with source:) That's what I was after.

comment:3 Changed 9 years ago by Ryan J Ollos

Owner: changed from Diorgenes Felipe Grzesiuk to Ryan J Ollos
Status: newaccepted

comment:4 Changed 7 years ago by Ryan J Ollos

Owner: Ryan J Ollos deleted
Status: acceptednew

comment:5 Changed 7 years ago by Ryan J Ollos

Fetching images should work correctly after r16785, but it would be better to get local attachments from the attachments directory rather than downloading them to a temp directory.

Modify Ticket

Change Properties
Set your email in Preferences
as new The ticket will remain with no owner.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.