Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11878 closed task (fixed)

Adoption request for AutocompleteUsersPlugin

Reported by: Tetsuya Morimoto Owned by: Ryan J Ollos
Priority: normal Component: AutocompleteUsersPlugin
Severity: normal Keywords: adoption-request
Cc: Jun Omae Trac Release: 1.0


Could you give me a permission as a maintainer to the repository?

Attachments (0)

Change History (9)

comment:1 Changed 4 years ago by Ryan J Ollos

We can maintain the plugin as co-maintainers. I'll get you setup with permissions in the next day or so.

comment:2 Changed 4 years ago by Tetsuya Morimoto

Did you finish that work? I'm not sure how to confirm ... :(

comment:3 Changed 4 years ago by Ryan J Ollos

I'll try to get to it today or tomorrow and will post here when its done.

comment:4 Changed 4 years ago by Ryan J Ollos

Cc: Jun Omae added; anonymous removed
Resolution: fixed
Status: newclosed

Sorry for the delay.

I've given you commit access to the repository and added you as a maintainer. I have a few requests:

  • Please continue to push changes to the SVN repository here, and keep your repository on GitHub synced to that if you choose.
  • Please try to keep your changes fine-grained enough that it is easy to review them (comment:6:ticket:8477). That is, one changeset per feature or fix, rather than blobs of changes that address multiple issues.

I have some changes from work on this plugin in Bloodhound that I'll likely be backporting.

Thanks for your help!

comment:5 Changed 4 years ago by Tetsuya Morimoto

In 14099:

Refs #11878

  • added as a test

comment:6 Changed 4 years ago by Tetsuya Morimoto

Thank you for accepting! I committed to confirm. :)

I agree with you and follow your requests. I'm thinking about the maintenance steps as below.

  1. release 0.4.2 without merging as a checkpoint
    • Though I might improve the egg package information ...
  2. merge my changes to next development trunk (0.4.3dev)
  3. release next version (0.4.3) including my changes or other fixes

Any comments are welcome.

comment:7 Changed 4 years ago by Ryan J Ollos

The release steps sound good to me. I'm not sure which versions of Trac / jQuery your changes are compatible with. I have little motivation to keep plugins compatible with Trac 0.11 these days. It would be nice if 0.4.2 and 0.4.3 work with Trac 0.12.x. I don't mind branching to have a 1.0.x compatible version though. My primary aim with this plugin, provided I ever find the time, is to get the plugin working well with Trac 1.0 and then integrate it to Trac.

comment:8 Changed 4 years ago by Tetsuya Morimoto

Got it. According to my changes, I confirmed it works on Trac 0.12.1 and 1.0.2. I'll do test simply for Trac 0.11 after merging. I'm going to release 0.4.x to support both Trac 0.12.x and 1.0.x compatible (might be 0.11), then release 0.5.x for Trac 1.0.x.

comment:9 Changed 4 years ago by Ryan J Ollos

Excellent plan. Thanks for your effort on this!

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.