Modify

Opened 3 years ago

Closed 3 years ago

#11899 closed defect (fixed)

Use of deprecated Environment.get_db_ctx which has been removed in trac:r13064

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Component: TracMigratePlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description (last modified by Jun Omae)

Remove uses of get_db_ctx and get_read_db method from the plugin. However, Environment.get_read_db will be removed in 1.3.1, according to trac:wiki:TracDev/ApiChanges/1.1.2#DatabaseAPIChanges.

Attachments (0)

Change History (6)

comment:1 Changed 3 years ago by Jun Omae

Description: modified (diff)

comment:2 Changed 3 years ago by Ryan J Ollos

Oddly the link trac:TracDev/ApiChanges/1.1.2#DatabaseAPIChanges seems to redirect back to trac:TracDev/ApiChanges. However it works if the realm is included: trac:wiki:TracDev/ApiChanges/1.1.2#DatabaseAPIChanges. Is that a bug or is that expected with a non-CamelCase page in the path?

comment:3 Changed 3 years ago by Jun Omae

Description: modified (diff)

It doesn't seem to be a bug. Wiki engine renders TracDev/ApiChanges linked to wiki page and /1.1.2#DatabaseAPIChanges as a plain text. So InterTrac feature with the text redirects TracDev/ApiChanges page.

However, that behavior is confusable when the entire of text is not a link....

comment:4 Changed 3 years ago by Jun Omae

In 14070:

tracmigrate: directly retreive database connection rather than deprecated Environment.get_db_cnx (refs #11899, trac:r13064)

comment:5 Changed 3 years ago by Jun Omae

In 14071:

tracmigrate: don't pass db parameter for Environment.get_version since the parameter has been removed in 1.1.2dev (refs #11899, trac:r12826)

comment:6 Changed 3 years ago by Jun Omae

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.