Modify

Opened 10 years ago

Closed 10 years ago

#11910 closed defect (fixed)

missing NULL value / white space check

Reported by: Genie Owned by: Jun Omae
Priority: normal Component: WikiGanttChartPlugin
Severity: major Keywords:
Cc: Trac Release:

Description

When you input a task as macro syntax, the summary value of task is not checked whether it is NULL.

If you input as below

{{{#!Gantt id="3124d31e34b1" style="red"
 , , 2014-08-01, 2014-08-31, 70%
}}}

No error occurred.

This is simple patch for it. Thank you so much...

  • wikiganttchart/web_ui.py

     
    376376                ntask['ratio'] = int(task['ratio'])
    377377
    378378            data = {}
    379             if 'name' in task:
     379            if task.get('name'):
    380380                data['subjectName'] = task['name']
    381381            else:
    382382                raise WikiGanttChartError(_("Task name is missing in line "

Attachments (1)

No_NULL_Chk_And_Wrong_Tooltip.png (16.3 KB) - added by Genie 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Genie

comment:1 Changed 10 years ago by Genie

And tooltip is wrong displayed.

comment:2 Changed 10 years ago by Jun Omae

In 14072:

WikiGanttChartPlugin: raise an error message if task name is empty (refs #11910)

comment:3 Changed 10 years ago by Jun Omae

In 14073:

WikiGanttChartPlugin: fixed tooltip wrongly showing with empty fields (refs #11910)

comment:4 Changed 10 years ago by Jun Omae

Status: newassigned

Thanks for your reporting! Would you please try the latest?

comment:5 Changed 10 years ago by Genie

That's perfect, and the font siez is go~~od.

It seems to stable now! Thank you so much.


Pray for Sewol.

comment:6 Changed 10 years ago by Jun Omae

Resolution: fixed
Status: assignedclosed

Thanks for the feedback! Closing this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.