Modify ↓

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11998 closed defect (fixed)

Wrong sort order

Reported by: anonymous Owned by: Jun Omae
Priority: normal Component: TracTicketChangelogPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

In 1.0dev version there is wrong sort order (see attach image). Changesets not sorting by Changesets numder.

Attachments (2)

sort.png​ (15.5 KB) - added by anonymous 10 years ago.
sort1.png​ (23.8 KB) - added by anonymous 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by anonymous

Attachment: sort.png​ added

comment:1 Changed 10 years ago by Jun Omae

Oops. That issue is introduced by my error in r14174. Could you please try the following?

  • ticketlog/web_ui.py

     
    192192            revision = {
    193193                'rev': rev,
    194194                'author': Chrome(self.env).format_author(req, author),
     195                'timestamp': timestamp,
    195196                'time': user_time(req, format_datetime,
    196197                                  from_timestamp(timestamp)),
    197198            }
    … …  
    204205            revision['link'] = intermediate[key]
    205206            revisions.append(revision)
    206207
    207         revisions.sort(key=lambda r: r['time'], reverse=True)
     208        revisions.sort(key=lambda r: r['timestamp'], reverse=True)
    208209
    209210        return revisions
    210211

Changed 10 years ago by anonymous

Attachment: sort1.png​ added

comment:2 in reply to:  1 Changed 10 years ago by anonymous

Replying to jun66j5:

Oops. That issue is introduced by my error in r14174. Could you please try the following?

all fine see attachment:sort1.png​

comment:3 Changed 10 years ago by Jun Omae

Resolution: → fixed
Status: new → closed

In 14192:

0.2dev: follow-ups to r14174, fixed wrong sort order of changesets (closes #11998)

comment:4 Changed 10 years ago by Jun Omae

In 14193:

1.0dev: merged [14192] from 0.2dev (refs #11998)

comment:5 Changed 10 years ago by Jun Omae

Owner: changed from Richard Liao to Jun Omae

Thanks for the feedback. The patch has been committed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.