PATCH: javascript not added to ticket page when using custom theme

[Cinc]

Hi,

we are using a Trac installation with a custom theme which doesn't have a banner at the top. Because of that the javascript file for filtering the milestones can't be added to the ticket pages with the current code.

I created a patch which uses add_script() instead of filtering to add the necessary script:

Trac/Plugins/SimpleMultiProject-0.0.4dev-py2.7.egg/simplemultiproject/ticket.py

@@ -88 +88 @@
 
     def filter_stream(self, req, method, filename, stream, data):
         if filename == "ticket.html":
+            add_script(req, "simplemultiproject/filter_milestones.js")
             # replace "project" text input (lineedit) for ticket editing with a selection field
             filter = Transformer('//input[@id="field-project"]')
             ticket_data = data['ticket']
 
-            script_filter = Transformer('//div[@id="banner"]')
-
             stream = stream | filter.replace(self._projects_field_ticket_input(req, ticket_data))
-            stream = stream | script_filter.before(self._update_milestones_script(req))
 
         return stream
 
-    def _update_milestones_script(self, req):
-        script = tag.script(type="text/javascript", src=req.href.chrome("simplemultiproject", "filter_milestones.js"))
-        return script
 
     def _add_milestones_maps(self, req, ticket_data):
 

Works like a charm over here.

Regards Cinc

[Cinc]

Patch for using add_script() when adding javascript to ticket page

[falkb]

Thank you! I've applied the patch to the local system here without seeing any problems. Gonna test it on another system soon... stay tuned!

[falkb]

In 14335:

, fixes #11573:
Thanks and kudos to Cinc for 2 nice patches!:

• better support of custom themes (fixes #12113)
• with [ticket-custom] option project = select , custom queries show project list as drop-down now
• additionally: show version drop-down in ticket-change form as ordered list now