Modify ↓

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12217 closed defect (fixed)

It's possible to create a custom field with the same name as a built in field [patch attached]

Reported by: pipern Owned by: Ryan J Ollos
Priority: normal Component: CustomFieldAdminPlugin
Severity: normal Keywords: patch
Cc: Trac Release:

Description

It's possible to use CustomFieldAdminPlugin's web UI to create a custom field named (for example) 'description'. This is later ignored by Trac, but is confusing for a user.

I've attached a patch which prevents the user being able to create a field with the same name as an existing field. There was already code to prevent a name collision with other custom fields.

Attachments (1)

avoid-new-custom-fields-with-same-name-as-builtin-fields.diff​ (882 bytes) - added by pipern 10 years ago.
Patch against r14260 to address #12217

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by pipern

Attachment: avoid-new-custom-fields-with-same-name-as-builtin-fields.diff​ added

Patch against r14260 to address #12217

comment:1 Changed 10 years ago by Ryan J Ollos

Owner: changed from osimons to Ryan J Ollos
Status: new → assigned

comment:2 Changed 10 years ago by Ryan J Ollos

Resolution: → fixed
Status: assigned → closed

In 14562:

0.2.12: Prevent creating custom field with name matching built-in.

Patch by Nick Piper. Fixes #12217.

comment:3 Changed 10 years ago by Ryan J Ollos

In 14567:

0.12.2: Fixed regression in [14562]. Refs #12217, #12299.

Only check that custom field doesn't match an existing field when creating the field, not when saving changes to the field.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.