Modify ↓

Opened 10 years ago

Closed 10 years ago

#12248 closed defect (fixed)

[patch] field_types incorrectly intialized (can break layout with textarea fields)

Reported by: bannerth.akos@… Owned by: bannerth.akos@…
Priority: high Component: CondFieldsPlugin
Severity: critical Keywords:
Cc: Trac Release: 0.11

Description (last modified by Ryan J Ollos)

It seems in revisions [12825] and [12827] the indentation of a for loop in web_ui.py was messed up - as a result the field_types are not initialized (only one item is added), which would be used in condfields.js to determine whether or not a field requires a full row (the 'textarea' type).

This can cause a completely broken layout, depending on the number and type of custom fields in some tracs.

Attachments (1)

condfields_indentation_fix.patch​ (716 bytes) - added by Akos Bannerth <bannerth.akos@…> 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Akos Bannerth <bannerth.akos@…>

Attachment: condfields_indentation_fix.patch​ added

comment:1 Changed 10 years ago by Ryan J Ollos

Description: modified (diff)

comment:2 Changed 10 years ago by Ryan J Ollos

Owner: set to bannerth.akos@…
Status: new → assigned

I think there might have been some tabs in the source code, and I didn't get the indentation correct when replacing them. Thanks for the patch.

comment:3 Changed 10 years ago by Ryan J Ollos

Resolution: → fixed
Status: assigned → closed

In 14505:

3.0dev: Fixed indentation errors in [12825] and [12827]. Fixes #12248.

Patch by bannerth.akos@….

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain bannerth.akos@….
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.