Ticketstats is not showing when reporting module is disabled

[Jorrit Schippers]

In my trac.ini I have trac.ticket.report.* = disabled because I like the query module better (see ​trac:wiki:TracReports). This module provides the REPORT_VIEW permission.

With the REPORT_VIEW permission gone, there is no way to get ticket stats working since [13100]. I propose that ticketstats implements IPermissionRequestor and adds REPORT_VIEW too. My test suggests that there is no error when two modules add the same permission.

[Jorrit Schippers]

quickfix

[Ryan J Ollos]

What if we test for REPORT_VIEW or TICKET_VIEW?

[Jorrit Schippers]

That seems like a proper solution too. I see that the required permission is not mentioned on the TracTicketStatsPlugin page. After you commit the change, maybe it is wise to put something up there so people know which permissions the plugin uses.

[Ryan J Ollos]

Replying to jorrit:

After you commit the change, maybe it is wise to put something up there so people know which permissions the plugin uses.

The wiki is editable by anyone and I review all the changes through the RSS feed. I appreciate if you can make the documentation change since I have trouble even keeping up with the tickets.

[Jorrit Schippers]

I did not realize that, I will do that when the change is committed.

[Ryan J Ollos]

In 14703:

3.0.0dev: Require TICKET_VIEW rather than REPORT_VIEW. Fixes #12307.

This revises [13100] and uses the same permission as QueryModule.