Refactoring and redesign

[Ryan J Ollos]

This is a general ticket for capturing refactoring and redesign changes that are needed for the plugin.

[Ryan J Ollos]

In 14605:

1.0.0dev: Use web_context rather than deprecated Context. Refs #12369.

[Ryan J Ollos]

In 14606:

1.0.0dev: Localized date format for code review comments.

The model has no knowledge of the Request object, which is the common pattern throughout the Trac codebase, and presumably an attribute of the MVC pattern. Refs #12369.

[Ryan J Ollos]

In 14607:

1.0.0dev: PEP-0008 and style changes. Refs #12369.

• Updated copyrights.
• Added Trac as an installation requirement.
• Removed unused imports.

[Ryan J Ollos]

In 14612:

1.0.0dev: Utilize Trac 1.2 database API. Refs #12369.

Compatibility with Trac 1.0 is provided through the methods in compat.py.

[Ryan J Ollos]

Any hints on why it is necessary to look for the form token in the cookie?: codereviewerplugin/1.0/coderev/web_ui.py@14611:113-126#L113​.

From what I can see, even in Trac 0.12 the form token should be retrieved from the cookie by the call to req.form_token:

• ​browser:/tags/trac-0.12/trac/web/main.py@:182#L163
• ​browser:/tags/trac-0.12/trac/web/main.py#L324

[Ryan J Ollos]

In 14653:

1.0.0dev: Always get form token from Request object. Refs #12369.

[Ryan J Ollos]

In 14680:

1.0.0dev: Insert schema when installing plugin. Refs #12369.

Previously all of the upgrade steps would be executed when installing the plugin at database version 3.

[Ryan J Ollos]

In 14681:

1.0.0dev: Avoid reparsing commit message. Refs #12369.

[Ryan J Ollos]

In 14682:

1.0.0dev: Remove unused parameter from private method. Refs #12369.

[Ryan J Ollos]

In 14683:

1.0.0dev: Extract function get_reviews_for_ticket. Refs #12369.

[Ryan J Ollos]

In 14684:

1.0.0dev: Refactor model. Refs #12369.

[Ryan J Ollos]

In 14686:

1.0.0dev: Fix type error on PostgreSQL. Refs #12369.

The issue will be avoided when the database tables are redesigned.

[Ryan J Ollos]

The plugin has reached a stable state from what I've seen. I'll create tickets for specific issues such as the table redesign.