Unicode character in ticket summary broken decoding in timeline

[massimo.b@…]

As described in ​http://trac.edgewall.org/ticket/12092#comment:8...

SimpleMultiProjectPlugin is breaking the unicode decoding of the timeline view. Using '&' in ticket summaries results in '&' in the timeline.

This is trac 1.0.5 and SimpleMultiProject svn trunk.

[anonymous]

Is this a new effect or does it happen since a certain revision?

[massimo.b@…]

Sorry, I never used a '&' character before in some summary. The original ticket already described the part of MultiProjectPlugin doing the wrong (?) decoding: simplemultiprojectplugin/trunk/simplemultiproject/timeline.py@14000:96#L86​

[falkb]

Thanks for the hint. I think I can reproduce it. Though need to find the time for debugging and fixing. I remember that puzzle was quite tricky there. If someone is faster than me, I'll appreciate the patch.

[falkb]

Please, could you try this patch and report back?:

timeline.py

@@ -8 +8 @@
 from trac.ticket.model import Ticket
 from simplemultiproject.model import *
 from trac.util.text import to_unicode
+from trac.util.html import unescape
 from trac.core import *
 from trac.web.api import IRequestFilter, ITemplateStreamFilter
 from operator import itemgetter
@@ -98 +99 @@
                 ticket_no = splitted_output[0].split('>')
                 if len(tooltip) == 3: #it's a ticket
                     #now rebuild the puzzle by inserting the name
-                    output = tag('Ticket' + ' ', tag.em(ticket_no[1], title=tooltip[1]), ' ', tag.span(self._current_project[self._read_idx], style="background-color: #ffffd0;"), splitted_output[1])
+                    output = tag('Ticket' + ' ', tag.em(ticket_no[1], title=tooltip[1]), ' ', tag.span(self._current_project[self._read_idx], style="background-color: #ffffd0;"), unescape(splitted_output[1]))
                 elif len(tooltip) == 1 and len(splitted_output) == 3: #it's an attachment
                     output += tag(' ', tag.span(self._current_project[self._read_idx], style="background-color: #ffffd0;"))
             return output

[massimo.b@…]

No, that did not help. The splitted_output seems to already have the wrong encoding.

[falkb]

I'm just thinking, not at the test bench at the moment. What about this?: splitted_output = unescape(to_unicode(output)).split("</em>")

[massimo.b@…]

No. I also tried some mutations of to_unicode and unescape, but it did not help.

[falkb]

Hmmm, now I got access to the test bench and my second patch (comment:6) works well for me. See

[falkb]

Did you really restart the webserver with the new plugin version? Otherwise I need such "bad" ticket summary for testing.

[massimo.b@…]

While being new to Trac development, I'm sure I reloaded the plugin. Writing some

output = tag('FOO-Ticket' + ' ',

rebuilding the egg, copy to the ./plugins folder and restarting the uWSGI processes (not the webserver) results in the FOO-Ticket in the timeline.

Currently I have that state:

simplemultiproject/timeline.py

@@ -8 +8 @@
 from trac.ticket.model import Ticket
 from simplemultiproject.model import *
 from trac.util.text import to_unicode
+from trac.util.html import unescape
 from trac.core import *
 from trac.web.api import IRequestFilter, ITemplateStreamFilter
 from operator import itemgetter
@@ -93 +94 @@
     
             if field == 'title': #now it's time to insert the project name
                 #split the whole string until we can insert
-                splitted_output = to_unicode(output).split("</em>")
+                splitted_output = unescape(to_unicode(output).split("</em>"))
                 tooltip = splitted_output[0].split('\"')
                 ticket_no = splitted_output[0].split('>')
                 if len(tooltip) == 3: #it's a ticket

I also tried a combination of the 2 patches.

I still have 'test & unicode testing' as summary in the ticket and 'test & unicode testing)' in the timeline.

[falkb]

Hi Massimo, please test this one (based on the SVN version):

timeline.py

@@ -8 +8 @@
 from trac.ticket.model import Ticket
 from simplemultiproject.model import *
 from trac.util.text import to_unicode
+from trac.util.html import Markup, unescape
 from trac.core import *
 from trac.web.api import IRequestFilter, ITemplateStreamFilter
 from operator import itemgetter
@@ -98 +99 @@
                 ticket_no = splitted_output[0].split('>')
                 if len(tooltip) == 3: #it's a ticket
                     #now rebuild the puzzle by inserting the name
-                    output = tag('Ticket' + ' ', tag.em(ticket_no[1], title=tooltip[1]), ' ', tag.span(self._current_project[self._read_idx], style="background-color: #ffffd0;"), splitted_output[1])
+                    ticket_summary = unescape(Markup(tooltip[1]))
+                    msg_text = unescape(Markup(splitted_output[1]))
+                    proj = self._current_project[self._read_idx]
+                    output = tag('Ticket' + ' ', tag.em(ticket_no[1], title=ticket_summary), ' ', tag.span(proj, style="background-color: #ffffd0;"), msg_text)
                 elif len(tooltip) == 1 and len(splitted_output) == 3: #it's an attachment
                     output += tag(' ', tag.span(self._current_project[self._read_idx], style="background-color: #ffffd0;"))
             return output

[massimo.b@…]

Yes, that fixed it, thanks. Please note when svn is fixed.

[falkb]

In 14624:

see #12375 fixed rendering of special chars in ticket summary

[massimo.b@…]

Replying to falkb:

In 14624: ...

I updated/reverted, tested successfully.

[falkb]

Thanks. The same here. I keep it open for a general testing period to see if people see issues with this change. Will close it in about 3 weeks.

[falkb]

Testing period over. No issues in a running production system.