Modify

Opened 7 years ago

Last modified 5 years ago

#12414 new enhancement

Implement REST interface to create and retrieve review data

Reported by: Ryan J Ollos Owned by:
Priority: normal Component: CodeReviewerPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description (last modified by Ryan J Ollos)

The current implementation of adding data and JavaScript in post_process_request request is fragile and I suspect the performance is not as good as it could be. Instead, we'll just add the scripts in post_process_request and retrieve the data through the REST interface. It should also be possible to add and delete reviews without refreshing the page.

Attachments (0)

Change History (4)

comment:1 Changed 7 years ago by Ryan J Ollos

Description: modified (diff)
Summary: Implement REST interface and AJAX callback to post/get review dataImplement REST interface to create and retrieve review data

comment:2 Changed 7 years ago by Ryan J Ollos

The issue with the current implementation, noted in comment:19:ticket:12412, is that a cached version of the changeset page may be used: browser:/tags/trac-1.0.6/trac/versioncontrol/web_ui/changeset.py@:322#L322. We append the data directly to the page, so when a cached page is used the data is stale.

comment:3 Changed 7 years ago by Ryan J Ollos

Owner: changed from Rob Guttman to Ryan J Ollos
Status: newassigned

comment:4 Changed 5 years ago by Ryan J Ollos

Owner: Ryan J Ollos deleted
Status: assignednew

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.