can't find image specified in theme.css

[galen_liu]

Customize theme: Advanced

with style:

#banner {
 background: url(header-bg2.png);
}

and I put header-bg2.png in my <trac_project>/htdocs/ The ThemeEnginePlugin can't find it.

Fix method:

admin.py

@@ -97 +97 @@
             return self._send_screenshot(req, data, path_info[11:])
         elif path_info == 'theme.css':
             req.send_file(os.path.join(self.env.path, 'htdocs', 'theme.css'), 'text/css')
-        
+        elif path_info.endswith('.png'):
+            req.send_file(os.path.join(self.env.path, 'htdocs', path_info), 'image/png')
+        elif path_info.endswith('.jpg'):
+            req.send_file(os.path.join(self.env.path, 'htdocs', path_info), 'image/jpeg')
+            
         raise HTTPNotFound("The requested URL was not found on this server")
     
     def _send_screenshot(self, req, data, name):

[Ryan J Ollos]

A workaround is to use ../chrome/site/header-bg2.png.

Since theme.css is located in the environment htdocs directory, we could just let Trac serve the file from the path /chrome/site/theme.css. That change would allow you to use url(header-bg2.png) in theme.css.

Proposed changes in attachment:t12550.patch​.

[Ryan J Ollos]

In 15011:

2.2.2dev: Extract local variable.

Refs #12550.

[Ryan J Ollos]

Simplified patch in attachment:t12550.1.patch​. The refactoring portion of attachment:t12550.patch​ was committed in [15011].

[Ryan J Ollos]

In 15025:

2.2.2dev: Let Trac serve theme.css

Fixes #12550.

[Ryan J Ollos]

If you can confirm that it's working well for you, I will create a tag for release 2.2.2.

[Ryan J Ollos]

In 15029:

2.2.2: Tag release 2.2.2

Refs #12549, #12550.

[Ryan J Ollos]

Release 2.2.2 can be found on ​PyPI.