#12556 closed defect (fixed)
Project filtering is broken on roadmap page when grouping is enabled
Reported by: | Cinc-th | Owned by: | Cinc-th |
---|---|---|---|
Priority: | normal | Component: | SimpleMultiProjectPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.12 |
Description
With [14992] and [14993] the roadmap page handling was rewritten. #12031 aims to link milestones and versions to one or more projects. Currently milestomes and versions without any link to a project are dropped from display when grouping is enabled. This may or may not be because of the recent changes.
Problem is that several SMP plugins add data in post_process_request() to the data dict given to the template in the end. This data may or may not have been filtered inside every single plugin according to the filter settings solely handled by SmpRoadmapProjectFilter.
Things are even worse because the execution order of post_process_request() is arbitrary so it's not ensured the filter plugin runs last (at least if you don't want to specify order in request_filters).
To fix the problem I intend to do the following:
- Create a new interface IPrepareRoadmapData
- Plugins may implement the interface to add/remove data from the data dictionary instead of using post_process_request()
- Use OrderedExtensionOption to specify a distinct order of execution
- Create a SmpRoadmapModule plugin to orchestrate everything by calling all the extensions in the given order during processing of post_process_request().
In 14999: