Modify ↓

Opened 9 years ago

Closed 9 years ago

#12564 closed task (fixed)

Refactor code

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: ServerSideRedirectPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

The code has been refactored and test cases added in [14979,14981-14984,14986,14988]. Additional changes will be committed against this ticket.

Attachments (3)

Screen Shot 2015-11-02 at 01.01.52.png​ (69.6 KB) - added by Ryan J Ollos 9 years ago.
Screen Shot 2015-11-02 at 01.20.04.png​ (65.4 KB) - added by Ryan J Ollos 9 years ago.
Screen Shot 2015-11-02 at 01.20.12.png​ (70.6 KB) - added by Ryan J Ollos 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by Ryan J Ollos

In 15012:

1.0.0dev: Avoid calling _get_redirect twice.

Refs #12564.

comment:2 Changed 9 years ago by Ryan J Ollos

In 15013:

1.0.0dev: Simplify code using concat_path_query_fragment

This change is a follow-on to [14979].

Refs #12564.

Changed 9 years ago by Ryan J Ollos

Attachment: Screen Shot 2015-11-02 at 01.01.52.png​ added

comment:3 Changed 9 years ago by Ryan J Ollos

The next change will remove the extra div in the message:

Changed 9 years ago by Ryan J Ollos

Attachment: Screen Shot 2015-11-02 at 01.20.04.png​ added

Changed 9 years ago by Ryan J Ollos

Attachment: Screen Shot 2015-11-02 at 01.20.12.png​ added

comment:4 Changed 9 years ago by Ryan J Ollos

After the changes:

comment:5 Changed 9 years ago by Ryan J Ollos

In 15014:

1.0.0dev: Remove extra div from redirect error message

This change also prepares the messages for translation.

Refs #12564.

comment:6 Changed 9 years ago by Ryan J Ollos

Resolution: → fixed
Status: new → closed

In 15084:

1.0.0: Release version 1.0.0

Fixes #12564.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.